⬆️ UPGRADE: Use pyScss instead of libsass

[hason]

Fix #195

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

[codecov]

Codecov Report

Merging #200 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
+ Coverage   91.56%   91.59%   +0.03%     
==========================================
  Files           2        2              
  Lines         237      238       +1     
==========================================
+ Hits          217      218       +1     
  Misses         20       20              

Flag	Coverage Δ
#pytests	91.59% <100.00%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sphinx_book_theme/__init__.py	91.56% <100.00%> (+0.05%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccff278...b9f550e. Read the comment docs.

[chrisjsewell]

Well I'm happy to merge this. @pradyunsg any objections?

[pradyunsg]

As long as pyscss is a drop-in-ish replacement to libsass in terms of syntax etc, no objections. :)

[pradyunsg]

And, thanks for checking! ^>^

[chrisjsewell]

And, thanks for checking! ^>^

Well its always nice to be kept in the loop. Which is apparently not part of the conda-forge policy 👀 conda-forge/staged-recipes#12511

[choldgraf]

+1 from me if it's more lightweight and the outputs are the same (which they seem to be)

[welcome]

Congrats on your first merged pull request in this project! 🎉


Thank you for contributing, we are very proud of you! ❤️

[chrisjsewell]

goddamit, straight after I merge, I find out that pyScss doesn't seem to support @use and only the defunct @import https://sass-lang.com/documentation/at-rules/import

[chrisjsewell]

linking Kronuz/pyScss#409

[chrisjsewell]

Err, I'm not sure about this compiler, now I start to see unadressed issues like this Kronuz/pyScss#370

[chrisjsewell]

Hmm, libsass doesn't seem to support it either? Or maybe its just me being a newb

[chrisjsewell]

it also doesn't support sourcemap generation Kronuz/pyScss#224

[pradyunsg]

:(

Are we OK with the GitHub repository not being directly-installable?

[chrisjsewell]

This is kind of funny; I created an issue about the maintenance status Kronuz/pyScss#410, mentioning a few PRs that had been open for months, and within a few hours 4 PRs had been merged of which I was thanked for one.

Its still an annoyance that source maps aren't available

Are we OK with the GitHub repository not being directly-installable?

I have no strong opinions on this, I rarely install directly from a repo.
You probably know more than most if this is an issue?