Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ NEW: Add translations for all buttons and tooltips #214

Merged
merged 3 commits into from
Sep 23, 2020

Conversation

chrisjsewell
Copy link
Member

closes #197

@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #214 into master will increase coverage by 0.49%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
+ Coverage   91.66%   92.15%   +0.49%     
==========================================
  Files           1        2       +1     
  Lines          72      102      +30     
==========================================
+ Hits           66       94      +28     
- Misses          6        8       +2     
Flag Coverage Δ
#pytests 92.15% <93.33%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sphinx_book_theme/translations/_convert.py 93.33% <93.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdd3519...ebbaa88. Read the comment docs.

@chrisjsewell
Copy link
Member Author

image

@chrisjsewell chrisjsewell merged commit d2a8b44 into master Sep 23, 2020
@chrisjsewell chrisjsewell deleted the add-translations branch September 23, 2020 05:32
@choldgraf
Copy link
Member

choldgraf commented Sep 23, 2020

nice - how did you generate these translations? I assume you do not speak all of these languages :-)

Could we document either in the contributors docs how this is structured, or the user docs how they can leverage this functionality? I suspect many are not familiar with Sphinx translation infra

@chrisjsewell
Copy link
Member Author

ဟုတ်ပါတယ်၊ ငါဒီဘာသာစကားအားလုံးကိုပြောတယ်။

@chrisjsewell
Copy link
Member Author

oletko lukenut kansion readme-tiedostoa?

@choldgraf
Copy link
Member

The existence/location of that readme file is precisely the kind of thing that would be helpful in developer documentation ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Sphinx language for some menu options
2 participants