Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS to center align images with class #292

Merged
merged 2 commits into from
Feb 26, 2021

Conversation

DrDrij
Copy link
Contributor

@DrDrij DrDrij commented Feb 25, 2021

This PR addresses #141 and jupyter-book/jupyter-book#1204 by defaultling img elements in the main content column to be centre alined.

Classes align-left and align-right will override as expected.

These behaviours now match default behaviours of figures.

@welcome
Copy link

welcome bot commented Feb 25, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@choldgraf
Copy link
Member

choldgraf commented Feb 25, 2021

nice! thanks very much 🎉

the failing test is annoyingly because sphinxcontrib-bibtex hasn't released a new version yet. Think you could post a screenshot of before/after so that it's clear what will change in the docs?

@DrDrij DrDrij changed the title Images default to centered, to match figures Add CSS to center align images with class Feb 26, 2021
@DrDrij
Copy link
Contributor Author

DrDrij commented Feb 26, 2021

Sure thing! Screenshots below. This PR simply adds the styles for class="align-center".

Before:

image

After:

image

@choldgraf
Copy link
Member

Nice! Thanks very much 🙂

@choldgraf choldgraf merged commit 4ab518e into executablebooks:master Feb 26, 2021
@welcome
Copy link

welcome bot commented Feb 26, 2021

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants