-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨IMPROVE: Move CSS hash to GET parameter #397
✨IMPROVE: Move CSS hash to GET parameter #397
Conversation
Looks like executablebooks/web-compile#5 was merged - once there's a release I can merge this one in, and cut a release of the book theme |
Already released as v0.2.2 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers, we also need to remove src/jinja/theme.conf.j2
(and its generation in web-compile-config.yml
) and then also change the name in sphinx_book_theme/theme.conf
(and remove the comment at the top of that file)
Oh wait, sorry I misread the code, yeh I see what's happening now |
for more information, see https://pre-commit.ci
it looks to be working to me! here's the relevant HTML from the RTD build:
|
Thanks for pushing to this and getting it over the line for me! |
Closes #376.
This PR makes use of the
hash
filter introduced in executablebooks/web-compile#5 (web compile will fail until this is merged and released) to add the hash to the URL at the end as a GET parameter rather than baking it into the filename.This means that when the file changes and the hash is updated the cache will be busted, but the file still has a consistent name for referencing in downstream themes.