Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: remove incorrect comment from sphinx pin. #588

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

rossbar
Copy link
Contributor

@rossbar rossbar commented Jul 15, 2022

The comment here was out-of-date (sphinx 5 has been released)
which made it unclear whether the pin was intentional or an
error. From the discussion in gh-583, it's now clear the pin
is intentional, so removing the comment for clarity.

Alternatively, the comment could be updated in a way that won't
be obsoleted by future sphinx releases - wording suggestions
welcome.

Closes #583

The comment here was out-of-date (sphinx 5 has been released)
which made it unclear whether the pin was intentional or an
error. From the discussion in executablebooksgh-583, it's now clear the pin
is intentional, so removing the comment for clarity.

Alternatively, the comment could be updated in a way that won't
be obsoleted by future sphinx releases - wording suggestions
welcome.
@choldgraf
Copy link
Member

Hmmm do things build as expected if you just remove it? Maybe this is old cruft from the past?

@pradyunsg
Copy link
Member

I think we'd need to update the footnotes CSS for Sphinx 5 -- that's all.

@choldgraf choldgraf merged commit 8307902 into executablebooks:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear sphinx pin in pyproject.toml
3 participants