Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Icon links, latest PST, more source providers, and bug fixes #691

Merged
merged 11 commits into from
Feb 27, 2023

Conversation

choldgraf
Copy link
Member

@choldgraf choldgraf commented Feb 23, 2023

This brings in the latest pydata theme, and along the way includes support for their icon-links buttons in our primary sidebar. We just inherit the component template and have some lightweight styling to make it look in-line with our documentation style.

Also adds support for more source button providers via the pydata theme:

@mmcky mmcky changed the title Icon links and latest pydata theme Icon links, latest pydata theme, and bug fixes Feb 24, 2023
@mmcky
Copy link
Member

mmcky commented Feb 24, 2023

Fixes the bug about builder.theme_options that @mmcky reported

thanks @choldgraf.

Once a new rc is available I will check against jupyter-book/jupyter-book#1842

docs/conf.py Outdated Show resolved Hide resolved
@choldgraf choldgraf changed the title Icon links, latest pydata theme, and bug fixes Icon links, latest pydata theme, more source providers, and bug fixes Feb 26, 2023
@choldgraf
Copy link
Member Author

OK this one now cleans up a bunch of different things, if we can get the tests passing, I'll merge so that we can cut a new release candidate since a lot of feedback was addressed and a couple new things were added.

@choldgraf choldgraf changed the title Icon links, latest pydata theme, more source providers, and bug fixes NEH: Icon links, latest PST, more source providers, and bug fixes Feb 27, 2023
@choldgraf choldgraf merged commit 9e2bc2f into executablebooks:master Feb 27, 2023
@choldgraf choldgraf changed the title NEH: Icon links, latest PST, more source providers, and bug fixes ENH: Icon links, latest PST, more source providers, and bug fixes Feb 27, 2023
@choldgraf
Copy link
Member Author

cc @mmcky - making a new release candidate now so try it out! :-)

https://github.com/executablebooks/sphinx-book-theme/releases/tag/v1.0.0rc3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants