FIX: properly handle CSS objects in css_files #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
previously approved these changes
Dec 12, 2023
agoose77
commented
Dec 12, 2023
agoose77
commented
Dec 12, 2023
| @@ -117,7 +131,7 @@ def hash_html_assets(app, pagename, templatename, context, doctree): | |||
| # run but the book theme CSS file won't be linked in Sphinx. | |||
| if app.config.html_theme == "sphinx_book_theme": | |||
| assets.append("styles/sphinx-book-theme.css") | |||
| hash_assets_for_files(assets, get_html_theme_path() / "static", context) | |||
| hash_assets_for_files(assets, get_html_theme_path() / "static", context, app) | |||
There was a problem hiding this comment.
This function is public, but I can't imagine anyone using it. Are you happy with the breaking change?
…lebooks/sphinx-book-theme into agoose77/fix-sphinx-726-warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sphinx 7.26 (approximately) deprecates implicit string operations on the contents of
context['css_files']. This, in turn, raises warnings for users that enable strict warning checks. This was observed injupyter-book's test-suite.This PR updates our handling to first assume objects within this list are
_CascadingStyleSheetobjects, and replaces the object back on the path.