Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs should include that sphinx_book_theme is required #38

Closed
Tracked by #649
goekce opened this issue Oct 29, 2021 · 2 comments · Fixed by #52
Closed
Tracked by #649

docs should include that sphinx_book_theme is required #38

goekce opened this issue Oct 29, 2021 · 2 comments · Fixed by #52
Labels
enhancement New feature or request

Comments

@goekce
Copy link

goekce commented Oct 29, 2021

Description / Summary

Without html_theme = 'sphinx_book_theme' in conf.py the exercise and solutions lack the icons on the top left side. It would be great if this theme is recommended in https://ebp-sphinx-exercise.readthedocs.io/en/latest/index.html#sphinx-project

To see the issue use the default theme html_theme = 'alabaster'

Value / benefit

People who are new to this project would spend less time for debugging :)

Implementation details

No response

Tasks to complete

No response

@goekce goekce added the enhancement New feature or request label Oct 29, 2021
@welcome
Copy link

welcome bot commented Oct 29, 2021

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@mmcky
Copy link
Member

mmcky commented Feb 17, 2022

thanks @goekce -- sorry this took me so long to get to.

I have now added this to the docs and opened #52

@mmcky mmcky closed this as completed in #52 Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants