Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 FIX: Check during doctree-resolve if env has attribute #16

Merged
merged 1 commit into from
Oct 10, 2020

Conversation

najuzilu
Copy link
Member

@najuzilu najuzilu commented Oct 8, 2020

This PR fixes doctree-resolve in the event that the extension is imported but not used.

@najuzilu najuzilu changed the title FIX: Check during doctree-resolve if env has attribute 🐛 FIX: Check during doctree-resolve if env has attribute Oct 8, 2020
@codecov-io
Copy link

Codecov Report

Merging #16 into master will decrease coverage by 0.27%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   96.80%   96.53%   -0.28%     
==========================================
  Files           3        3              
  Lines         344      346       +2     
==========================================
+ Hits          333      334       +1     
- Misses         11       12       +1     
Flag Coverage Δ
#pytests 96.53% <50.00%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sphinx_exercise/__init__.py 94.85% <50.00%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22f8c36...0de1f68. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants