Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌️ IMPROVE: Add tox.ini #26

Merged
merged 3 commits into from
Sep 7, 2020
Merged

👌️ IMPROVE: Add tox.ini #26

merged 3 commits into from
Sep 7, 2020

Conversation

najuzilu
Copy link
Member

@najuzilu najuzilu commented Sep 2, 2020

This PR adds tox.ini file

@najuzilu najuzilu changed the title 🔧 [MAINTAIN] Add tox.ini [MAINTAIN] Add tox.ini Sep 2, 2020
@najuzilu
Copy link
Member Author

najuzilu commented Sep 2, 2020

Failed attempt at using emojis in PR title...

@mmcky
Copy link
Member

mmcky commented Sep 3, 2020

I am still learning tox myself -- looks nice.

@AakashGfude
Copy link
Member

@najuzilu once you have updated the docs about how to run it locally, and happy with it. Will love to give this is a spin and see how it works 🙂

@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   97.09%   97.09%           
=======================================
  Files           6        6           
  Lines         241      241           
=======================================
  Hits          234      234           
  Misses          7        7           
Flag Coverage Δ
#pytests 97.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24489b2...ebc0a09. Read the comment docs.

@najuzilu najuzilu changed the title [MAINTAIN] Add tox.ini 👌️ IMPROVE: Add tox.ini Sep 4, 2020
@AakashGfude
Copy link
Member

Hey @najuzilu did you get the same error at some point? is it path/env issue?
image

@najuzilu
Copy link
Member Author

najuzilu commented Sep 7, 2020

Not familiar with this error but I notice that you're using myst-conda-env3. I would suggest trying a new environment with pip install -e .[rtd] and trying again. Maybe that might fix it.

@AakashGfude
Copy link
Member

@najuzilu tried that as well. still not working :(

@AakashGfude
Copy link
Member

above error was tox 2.5.0 issue. apparently it does not work in that version. But that version is pretty old as well, so approving this.

@najuzilu najuzilu merged commit 9868af3 into master Sep 7, 2020
@najuzilu najuzilu deleted the add-tox-ini branch September 7, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants