Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨️ NEW: Add MANIFEST file #31

Merged
merged 4 commits into from
Sep 17, 2020

Conversation

AakashGfude
Copy link
Member

On checking the source distribution package for this, found that some files like LICENSE and _static were missing.
So, adding a MANIFEST file.

cc: @najuzilu

@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #31   +/-   ##
=======================================
  Coverage   97.09%   97.09%           
=======================================
  Files           6        6           
  Lines         241      241           
=======================================
  Hits          234      234           
  Misses          7        7           
Flag Coverage Δ
#pytests 97.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfe1376...dbaa712. Read the comment docs.

Copy link
Member

@najuzilu najuzilu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're going with a Manifest file, I would suggest we remove include_package_data=True under setup.py. What do you think @AakashGfude?

@AakashGfude
Copy link
Member Author

AakashGfude commented Sep 15, 2020

Since we're going with a Manifest file, I would suggest we remove include_package_data=True under setup.py. What do you think @AakashGfude?

Thanks @najuzilu, I guess what you meant was remove package_data={"sphinxcontrib": ["_static/*"]} ? Have removed it now.

@mmcky mmcky requested a review from najuzilu September 17, 2020 04:33
Copy link
Member

@najuzilu najuzilu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @AakashGfude!

@najuzilu najuzilu merged commit edba090 into executablebooks:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants