-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨️ NEW: Add MANIFEST file #31
Conversation
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
=======================================
Coverage 97.09% 97.09%
=======================================
Files 6 6
Lines 241 241
=======================================
Hits 234 234
Misses 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're going with a Manifest file, I would suggest we remove include_package_data=True
under setup.py
. What do you think @AakashGfude?
Thanks @najuzilu, I guess what you meant was remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks @AakashGfude!
On checking the source distribution package for this, found that some files like
LICENSE
and_static
were missing.So, adding a MANIFEST file.
cc: @najuzilu