Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: update testing against sphinx6, drop sphinx3 #57

Merged
merged 5 commits into from
Jan 5, 2023
Merged

Conversation

mmcky
Copy link
Member

@mmcky mmcky commented Nov 14, 2022

This PR updates the testing infrastructure to test against sphinx4 and sphinx5 and sphinx6 (dropping sphinx3).

It also replaces sphinx-panels with sphinx-design as sphinx-panels is now deprecated.

@welcome
Copy link

welcome bot commented Nov 14, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@mmcky
Copy link
Member Author

mmcky commented Nov 14, 2022

  • this is dependent on sphinx-book-theme which is currently set to sphinx<5 so it is currently testing sphinx==4.5. This PR has been tested on sphinx5

@choldgraf
Copy link
Member

Happy to review a PR over in the book theme to bump it up to Sphinx 5 compatibility. I believe it already supports Sphinx > 4: https://github.com/pydata/pydata-sphinx-theme/blob/3ac01cf378b4f58f8c4c411a82fb85324c909ef0/pyproject.toml#L22-L28

maybe @AakashGfude can wrap this into the cruft-removing PR that he is taking over

@mmcky
Copy link
Member Author

mmcky commented Nov 24, 2022

  • waiting on new release of sphinx-book-theme before finalising

@choldgraf choldgraf changed the title MAINT: update testing against sphinx5, drop sphinx3 MAINT: update testing against sphinx6, drop sphinx3 Jan 5, 2023
@choldgraf
Copy link
Member

choldgraf commented Jan 5, 2023

OK we now have the latest version of the book theme in pre-release:

I've updated setup.py to install the pre-release from the docs, and went ahead and bumped to Sphinx 6 support as well. I'm starting to feel more that we should just drop the upper bound of Sphinx, it is really tedious to have to keep bumping versions across all of these repositories. But that's a conversation for another day.

I think we should merge this and make a release if the tests pass and the docs look good. They look normal to me so I'm gonna merge.

@choldgraf choldgraf merged commit 168dc9a into master Jan 5, 2023
@welcome
Copy link

welcome bot commented Jan 5, 2023

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants