Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network: Widget Activation Threshold is applied backwards #1958

Closed
cjthompson opened this issue May 21, 2024 · 1 comment
Closed

Network: Widget Activation Threshold is applied backwards #1958

cjthompson opened this issue May 21, 2024 · 1 comment
Labels
Need to be fixed Need to be fixed

Comments

@cjthompson
Copy link

cjthompson commented May 21, 2024

This logic is backwards.

I presume that the feature is "If the current upload or download value in bytes is LESS THAN the threshold value, then display 0"

Currently, the logic is applied backwards. The upload and download values are set to 0 if they a GREATER than the threshold. If you set "Widget Activation Threshold" to "1 Byte", the widget will always display "0".

if value.bandwidth.upload >= threshold || value.bandwidth.download >= threshold {

The logic was reversed in this commit

Screenshot 2024-05-21 at 8 14 26 AM

@exelban
Copy link
Owner

exelban commented May 21, 2024

hi. Thanks for the feedback.
Yeap, looks like I messed up with that(
Will be fixed.

@exelban exelban added the Need to be fixed Need to be fixed label May 21, 2024
@exelban exelban added this to Stats May 21, 2024
@exelban exelban moved this to In Progress in Stats May 21, 2024
@exelban exelban moved this from In Progress to Ready to deploy in Stats May 23, 2024
@exelban exelban closed this as completed May 26, 2024
@github-project-automation github-project-automation bot moved this from Ready to deploy to Done in Stats May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Need to be fixed Need to be fixed
Projects
Status: Done
Development

No branches or pull requests

2 participants