Arrays concept part 2 #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsaacG
reviewed
Feb 22, 2025
| echo "${myarray[*]}" | ||
| ``` | ||
|
|
||
| You are required to enclose the expansion in double quotes. |
There was a problem hiding this comment.
There's no actual "requirement" as much as a "should" to avoid glob expansion.
There was a problem hiding this comment.
The requirement is that the concatenate behaviour only applies when the expansion is quoted. Otherwise you get word splitting.
In the manual:
If the word is double-quoted,
${name[*]}expands to a single word with the value of each array member separated by the first character of theIFSvariable,
| # => "one:two:three:four" | ||
| ``` | ||
|
|
||
| Localizing `IFS` in the function means we don't have to save the old value and restore it back to it's previous value in the global scope. |
There was a problem hiding this comment.
FWIW a subshell is a (simpler?) alternative.
array=(one two three)
( IFS=,; echo "${array[*]}"; )| set -- one two three | ||
| set -- "$@" four | ||
|
|
||
| for item in "$@"; do |
There was a problem hiding this comment.
FWIW you can also omit the in "$@"
There was a problem hiding this comment.
Yes, but let's be explicit
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
IsaacG
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.