Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update config.json and add hello-world exercise #3

Merged
merged 17 commits into from
Jan 9, 2024

Conversation

GroophyLifefor
Copy link
Member

@ErikSchierboom
I made some changes to add the first exercise but I'm stuck on the Setup Continuous Integration step, I know how to use GitHub Actions, I know how CI/CD works, and I know how Unix works, but the problem is that I don't know how to go about testing it.

#1

@GroophyLifefor GroophyLifefor linked an issue Jan 5, 2024 that may be closed by this pull request
11 tasks
Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least the missing EOL is consistent in these three batch files, but the last line should be consistent as the line before it with an End of Line at the end of it.

exercises/practice/hello-world/src/main/Greeter.bat Outdated Show resolved Hide resolved
exercises/practice/hello-world/src/test/GreeterTest.bat Outdated Show resolved Hide resolved
GroophyLifefor and others added 3 commits January 7, 2024 19:24
EOL added to hello world exercise's reference.

Co-authored-by: Victor Goff <keeperotphones@gmail.com>
EOL added to hello world exercise's source(src).

Co-authored-by: Victor Goff <keeperotphones@gmail.com>
EOL added to hello world exercise's test file.

Co-authored-by: Victor Goff <keeperotphones@gmail.com>
@GroophyLifefor
Copy link
Member Author

@kotp Should I merge it now or wait for Erik to see it?

Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, with comments to consider. Non-blocking, only things I noted while reviewing.

exercises/practice/hello-world/.docs/instructions.md Outdated Show resolved Hide resolved
exercises/practice/hello-world/src/test/GreeterTest.bat Outdated Show resolved Hide resolved
@kotp
Copy link
Member

kotp commented Jan 7, 2024

@kotp Should I merge it now or wait for Erik to see it?

I would wait for 2 more approvals, if possible, and not rush it really. Erik will see it and recognize anything that he knows to look for in terms of construction and organization in terms of the platform. Otherwise may know to look for Batch Script specific things, others will look at content and understanding in other ways.

@GroophyLifefor
Copy link
Member Author

@kotp Should I merge it now or wait for Erik to see it?

I would wait for 2 more approvals, if possible, and not rush it really. Erik will see it and recognize anything that he knows to look for in terms of construction and organization in terms of the platform. Otherwise may know to look for Batch Script specific things, others will look at content and understanding in other ways.

I will take your advice and wait for Erik's guidance, I am in no hurry, it is more important to move forward correctly.

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I've left some comments

config.json Outdated Show resolved Hide resolved
config.json Outdated Show resolved Hide resolved
exercises/practice/hello-world/src/main/Greeter.bat Outdated Show resolved Hide resolved
exercises/practice/hello-world/src/main/Greeter.bat Outdated Show resolved Hide resolved
@ErikSchierboom
Copy link
Member

I'm stuck on the Setup Continuous Integration step, I know how to use GitHub Actions, I know how CI/CD works

Don't worry about that, I'm happy to help. Let's first focus on getting this PR merged, then on creating a basic test runner and then I can do the CI bit for you.

config.json Outdated Show resolved Hide resolved
exercises/practice/hello-world/src/main/Greeter.bat Outdated Show resolved Hide resolved
@GroophyLifefor
Copy link
Member Author

Don't worry about that, I'm happy to help. Let's first focus on getting this PR merged, then on creating a basic test runner and then I can do the CI bit for you.

Thanks you, I'm currently focused on this PR. <3

GroophyLifefor and others added 2 commits January 9, 2024 14:48
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Let's move on to the test runner: https://github.com/exercism/batch-test-runner

For clarification: the test runner is the software that runs automatically when someone submits an iteration. The goal of the test runner is to verify that the student's code passes all the tests. Our challenge will be to run batch code in Linux, as that is what our test runners have to use. See https://exercism.org/docs/building/tooling/test-runners for more information.

I've just created the test runner repo: https://github.com/exercism/batch-test-runner The repo contains a basic starting point to iterate from.

@ErikSchierboom ErikSchierboom merged commit 7e2867f into main Jan 9, 2024
1 check passed
GroophyLifefor added a commit that referenced this pull request Jan 12, 2024
feat: update config.json and add hello-world exercise (#3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launch tracking
3 participants