Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Add file patterns to config.json #628

Merged
merged 5 commits into from
Feb 24, 2021

Conversation

ErikSchierboom
Copy link
Member

⚠ This PR requires you to make a simple change before merging. ⚠


To save maintainers from having to manually specify the files key in their exercises' .meta/config.json files, we are providing support for track-level patterns. See this PR for details.

This PR adds (purposefully wrong) file patterns to the config.json file. It is up to you, the track maintainers, to change these patterns to their correct value.

You can use the following placeholders:

  • %{kebab_slug}: the kebab-case exercise slug (e.g. bit-manipulation)
  • %{snake_slug}: the snake_case exercise slug (e.g. bit_manipulation)
  • %{camel_slug}: the camelCase exercise slug (e.g. bitManipulation)
  • %{pascal_slug}: the PascalCase exercise slug (e.g. BitManipulation)

We will soon update configlet to enable it to automatically populate the .meta/config.json file's files property, at which point we will then batch-PR updates to all tracks that have merged this PR.

Tracking

exercism/v3-launch#19

@wolf99
Copy link
Contributor

wolf99 commented Feb 22, 2021

Have an open question on slack about my changes... not quite sure if the makefile needs to be duplicated between stub and the solution. Also if the example files need to stay example or not (https://exercism-team.slack.com/archives/CR91YFNG3/p1614027093008400?thread_ts=1613575298.444300&cid=CR91YFNG3)

@ErikSchierboom
Copy link
Member Author

@wolf99 I've responded on Slack

Comment on lines +998 to -987
"typing/static",
"platform/android",
"platform/ios",
"platform/linux",
"platform/mac",
"platform/windows",
"runtime/language_specific",
"typing/static",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was typing/static reordered here? It looks like it's otherwise in alphabetical order.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the v3 website (currently) the first three tags are listed beneath the track name in the listing of tracks.
This means that "platform/android" is one of the listed items. This changes that, making the tag used more relevant to the language.

I based this change in the thought that although C can indeed be used on Android, Android is not necessarily required to create C programs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wolf99 wolf99 merged commit 5c3ce63 into exercism:main Feb 24, 2021
@ErikSchierboom ErikSchierboom added the x:size/tiny Tiny amount of work label Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/tiny Tiny amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants