-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🤖 Add file patterns to config.json #628
Conversation
Just me being pedantic
Have an open question on slack about my changes... not quite sure if the |
@wolf99 I've responded on Slack |
"typing/static", | ||
"platform/android", | ||
"platform/ios", | ||
"platform/linux", | ||
"platform/mac", | ||
"platform/windows", | ||
"runtime/language_specific", | ||
"typing/static", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was typing/static
reordered here? It looks like it's otherwise in alphabetical order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the v3 website (currently) the first three tags are listed beneath the track name in the listing of tracks.
This means that "platform/android" is one of the listed items. This changes that, making the tag used more relevant to the language.
I based this change in the thought that although C can indeed be used on Android, Android is not necessarily required to create C programs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
⚠ This PR requires you to make a simple change before merging. ⚠
To save maintainers from having to manually specify the
files
key in their exercises'.meta/config.json
files, we are providing support for track-level patterns. See this PR for details.This PR adds (purposefully wrong) file patterns to the
config.json
file. It is up to you, the track maintainers, to change these patterns to their correct value.You can use the following placeholders:
%{kebab_slug}
: thekebab-case
exercise slug (e.g.bit-manipulation
)%{snake_slug}
: thesnake_case
exercise slug (e.g.bit_manipulation
)%{camel_slug}
: thecamelCase
exercise slug (e.g.bitManipulation
)%{pascal_slug}
: thePascalCase
exercise slug (e.g.BitManipulation
)We will soon update
configlet
to enable it to automatically populate the.meta/config.json
file'sfiles
property, at which point we will then batch-PR updates to all tracks that have merged this PR.Tracking
exercism/v3-launch#19