New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wordy Exercise #296

Merged

0xNeshi merged 45 commits into exercism:main from Ephraim-nonso:main

Oct 18, 2024

Contributor

Ephraim-nonso commented Oct 14, 2024 •

edited by 0xNeshi

Loading

Closes #250

This is the wordy exercise practice.

Ephraim-nonso and others added 30 commits

July 10, 2024 01:32


          Added introduction for strings

91d8a54


          Added blurb for strings

e90852c


          Changed to review

ac52fe1


          One change

e865f05


          Change wordings for clarity

96d9bca


          Enums Data Type

52de5af


          Merge branch 'exercism:main' into main

74f359c


          Update:Changes on Enums Data Type

c96e3f4


          Merge branch 'exercism:main' into main

009cf95


          Update:Changes on Enums Data Type

8a8a8cf


          New:Changes on Enums Data Type

978ac07


          Merge branch 'exercism:main' into main

70ebe7e


          Reorder sentences in Enum Traits section

8a4a4e7


          Match basics concept

e3544cb


          Merge branch 'main' into main

49d20ee


          reorder enum & match basics

321923e


          resolve enumn clash

89d0d01


          Merge branch 'exercism:main' into main

9456bba


          amend to requested changes

d031586


          Merge remote-tracking branch 'refs/remotes/origin/main'

2262bd4


          minor changes

d77ac92


          Merge branch 'exercism:main' into main

100e118


          nit: code update

98ddc2c


          Merge branch 'exercism:main' into main

df51470


          Apply suggestions from code review

ecdd0b6


          traits concept

b8adcde


          Merge remote-tracking branch 'refs/remotes/origin/main'

63bddac


          Merge branch 'main' into main

b1a4c1f


          correction to traits concept

066787c


          Merge branch 'exercism:main' into main

9ac273e

Ephraim-nonso added 4 commits

September 20, 2024 21:24


          few correction on traits

69dab2f


          Merge branch 'exercism:main' into main

3b851a6


          wordy exercise

eca178d


          pass checks

35e9e18

github-actions bot commented Oct 14, 2024

Hello 👋 Thanks for your PR.

This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed.

If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track.

Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum.

(cc @exercism/cross-track-maintainers)

0xNeshi assigned Ephraim-nonso

0xNeshi requested changes

View reviewed changes

Contributor

0xNeshi left a comment

Good first iteration, let's polish it a bit

exercises/practice/wordy/.meta/example.cairo Outdated Show resolved Hide resolved

exercises/practice/wordy/.meta/example.cairo Outdated Show resolved Hide resolved

exercises/practice/wordy/.meta/example.cairo Show resolved Hide resolved

exercises/practice/wordy/.meta/example.cairo Outdated Show resolved Hide resolved

exercises/practice/wordy/.meta/example.cairo Outdated Show resolved Hide resolved

exercises/practice/wordy/.meta/example.cairo Outdated Show resolved Hide resolved

exercises/practice/wordy/.meta/example.cairo Outdated Show resolved Hide resolved

exercises/practice/wordy/.meta/config.json Outdated Show resolved Hide resolved

config.json Outdated Show resolved Hide resolved

config.json Show resolved Hide resolved


          Merge branch 'main' into main

2b54929

0xNeshi reviewed

View reviewed changes

exercises/practice/wordy/.meta/example.cairo Outdated Show resolved Hide resolved

Ephraim-nonso added 5 commits

October 17, 2024 14:53


          Wordy: update fmt

26ff5d6


          Wordy: update fmt

925e6af


          wordy: formatted

008fd0e


          wordy: formatted

281fd43


          wordy: formatted

9f03b7f

Ephraim-nonso requested a review from 0xNeshi

October 17, 2024 14:36

0xNeshi requested changes

View reviewed changes

Contributor

0xNeshi left a comment

Looks much better, a couple small things to address and we can merge

exercises/practice/wordy/.meta/example.cairo Outdated Show resolved Hide resolved

exercises/practice/wordy/src/lib.cairo Outdated Show resolved Hide resolved

exercises/practice/wordy/.meta/example.cairo Outdated Show resolved Hide resolved

exercises/practice/wordy/.meta/example.cairo Outdated Show resolved Hide resolved

exercises/practice/wordy/.meta/example.cairo Outdated Show resolved Hide resolved

Ephraim-nonso and others added 2 commits

October 18, 2024 13:16


          wordy: error handling.

df78767


          Update exercises/practice/wordy/src/lib.cairo

0xNeshi reviewed

View reviewed changes

config.json Outdated Show resolved Hide resolved


          Update difficulty to 4

0c7ed6b

0xNeshi reviewed

View reviewed changes

exercises/practice/wordy/.meta/example.cairo Outdated Show resolved Hide resolved

0xNeshi reviewed

View reviewed changes

exercises/practice/wordy/.meta/example.cairo Outdated Show resolved Hide resolved


          rename max->num in parse_int

0xNeshi approved these changes

View reviewed changes

Contributor

0xNeshi left a comment

Good work 🚀

0xNeshi merged commit f9f93ae into exercism:main

6 checks passed

0xNeshi added x:module/practice-exercise x:type/content x:rep/large x:action/create x:type/coding labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:action/create x:module/practice-exercise x:rep/large x:type/coding x:type/content