Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isbn verifier #309

Merged
merged 15 commits into from
Nov 16, 2024
Merged

isbn verifier #309

merged 15 commits into from
Nov 16, 2024

Conversation

Falilah
Copy link
Contributor

@Falilah Falilah commented Nov 15, 2024

Closes #192

Copy link

Hello 👋 Thanks for your PR.

This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed.

If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track.

Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum.

(cc @exercism/cross-track-maintainers)

Copy link
Contributor

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @Falilah, this is really some idiomatic, clear and clean Cairo code 🚀

Just a couple of smaller things to address, and we're good to merge!

exercises/practice/isbn-verifier/src/lib.cairo Outdated Show resolved Hide resolved
config.json Outdated Show resolved Hide resolved
exercises/practice/isbn-verifier/.meta/example.cairo Outdated Show resolved Hide resolved
exercises/practice/isbn-verifier/.meta/example.cairo Outdated Show resolved Hide resolved
@0xNeshi 0xNeshi added x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) x:rep/large Large amount of reputation x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises) labels Nov 15, 2024
@Falilah Falilah requested a review from 0xNeshi November 16, 2024 08:17
Copy link
Contributor

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving this ❤️‍🔥

@0xNeshi 0xNeshi merged commit 8cb3179 into exercism:main Nov 16, 2024
6 checks passed
@Falilah
Copy link
Contributor Author

Falilah commented Nov 17, 2024

Loving this ❤️‍🔥

thank you very much 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises) x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Practice Exercise: isbn-verifier
2 participants