Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dup alias "t", keep it for "test" only #1159

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

muzimuzhi
Copy link
Contributor

Command alias "t" was registered by both "troubleshoot" and "test" commands. This PR drops it from "troubleshoot" aliases.

Command alias "t" was registered by both "troubleshoot" and "test"
commands. This PR drops it from "troubleshoot" aliases.
Copy link

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Aug 20, 2024
@ErikSchierboom
Copy link
Member

@muzimuzhi Having slept on it a bit, I think my previous suggestion was wrong. We should keep the existing t shortcut for troubleshoot as to not cause any breaking changes. Maybe we can use another letter for the test command, e.g. e? (if that's unused)

@muzimuzhi
Copy link
Contributor Author

muzimuzhi commented Aug 21, 2024

We should keep the existing t shortcut for troubleshoot as to not cause any breaking changes.

I believe it's already been a regression starting from versions 3.2.0 (2023-08-01), that exercism t stopped resolving to troubleshoot command, but to test. The culprit commit is a8ffc31.

I'll adjust this PR to drop t alias from test command instead.

If assigning single-character aliases for each command is an important convention, compared to e, uppercase T might be better. e can be reserved for future command which starts with e, for example explore.

@ErikSchierboom
Copy link
Member

I believe it's already been a regression starting from versions 3.2.0 (2023-08-01), that exercism t stopped resolving to troubleshoot command, but to test. The culprit commit is a8ffc31.

Right, then I'm fine with keep it as is.

@ErikSchierboom ErikSchierboom merged commit 8951e55 into exercism:main Aug 21, 2024
7 checks passed
@muzimuzhi muzimuzhi deleted the fix/dup-alias-t branch August 21, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants