Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BinaryName initialization from args #1174

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

petrem
Copy link
Contributor

@petrem petrem commented Sep 27, 2024

Fixes an issue with completion bash where the command name is not present in the completion output.

Fixes an issue with `completion bash` where the command name is not present
in the completion output.
Copy link

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Sep 27, 2024
@iHiD iHiD reopened this Sep 28, 2024
@iHiD
Copy link
Member

iHiD commented Sep 28, 2024

Forum discussion: https://forum.exercism.org/t/exercism-completion-bash-not-working/13100/2

(cc @exercism/cli)

Copy link
Contributor

@glennj glennj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know go all that well. This looks reasonable.

@iHiD
Copy link
Member

iHiD commented Oct 4, 2024

@ErikSchierboom Are you ok to merge/release this when you're back around pls?

@ErikSchierboom ErikSchierboom merged commit d3b5d7f into exercism:main Oct 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants