Update instructions.md #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inclusion of the word "positive" is redundant given the context. Moreover, it is inconsistent with the test suite. The test suite expects a result of 0.5 for a balance of 0, which is not a positive number.
bobbicodes
previously requested changes
Jun 19, 2022
exercises/concept/interest-is-interesting/.docs/instructions.md
Outdated
Show resolved
Hide resolved
exercises/concept/interest-is-interesting/.docs/instructions.md
Outdated
Show resolved
Hide resolved
|
This PR is basically ready, but conflicts with a very recent commit that already applied Bobbi's suggestions. I'm going to resolve the conflicts and then merge, provided no further changes are necessary. |
tasxatzial
approved these changes
Sep 14, 2024
tasxatzial
dismissed
bobbicodes’s stale review
Suggestions already applied in #608
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inclusion of the word "positive" is redundant given the context. Moreover, it is inconsistent with the test suite. The test suite expects a result of 0.5 for a balance of 0, which is not a positive number.