Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robot simulator: Sync with problem-specifications #574

Merged
merged 4 commits into from
Jul 18, 2023

Conversation

tasxatzial
Copy link
Member

@tasxatzial tasxatzial commented Jul 17, 2023

Closes #456

Complete re-write of tests. Took way longer than expected because I wasn't able to decide what's the most appropriate way to write them. So, i just picked the one that looked best to me.

This PR is not expected to break existing solutions

@github-actions
Copy link
Contributor

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jul 17, 2023
@tasxatzial
Copy link
Member Author

tasxatzial commented Jul 17, 2023

Don't approve yet. Just open. There's an error i have to fix.

Edit: Not sure why the tests did not fail though.

@tasxatzial
Copy link
Member Author

tasxatzial commented Jul 17, 2023

Ok, fixed, it was a just a deftest declared twice.

Edit: I'll push when the PR is re opened.

@bobbicodes bobbicodes reopened this Jul 17, 2023
@bobbicodes bobbicodes merged commit 1f535a1 into exercism:main Jul 18, 2023
2 checks passed
@tasxatzial tasxatzial deleted the robot-simulator-p1 branch September 22, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests in Robot Simulator are overly prescriptive
2 participants