Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

space-age: Sync #647

Merged
merged 3 commits into from
Jun 22, 2024
Merged

space-age: Sync #647

merged 3 commits into from
Jun 22, 2024

Conversation

tasxatzial
Copy link
Member

@tasxatzial tasxatzial commented Jun 22, 2024

For #48in24

Sync docs, metadata, tests

The existing implementation of the tests uses a separate function for each planet, but the last test (unknown planet as input) in canonical data implies that there should be only one function for all tests. Changing the tests to reflect that will break all solutions, so at this point, i decided to just mark the test as excluded.

Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jun 22, 2024
@ErikSchierboom ErikSchierboom merged commit 058660d into exercism:main Jun 22, 2024
5 checks passed
@tasxatzial tasxatzial deleted the space-age-sync branch June 22, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants