Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix grammar issues in functions generating functions concept #664

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

tasxatzial
Copy link
Member

No description provided.

Copy link
Contributor

github-actions bot commented Sep 7, 2024

Hello 👋 Thanks for your PR.

This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed.

If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track.

Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum.

(cc @exercism/cross-track-maintainers)

@BNAndras BNAndras merged commit 7b46e1f into exercism:main Sep 8, 2024
4 checks passed
@tasxatzial tasxatzial deleted the functions-generating branch September 8, 2024 04:54
@michalporeba
Copy link
Contributor

@BNAndras, why did you merge the commit with an outstanding review question without commenting on it?

@BNAndras
Copy link
Member

BNAndras commented Sep 8, 2024

My apologies! I didn’t mean to cause any offense.

The repo is marked as maintained-solitary on Exercism (https://exercism.org/maintaining/track_categories) so a cross-track-maintainer would be expected to be involved in a review. This PR was pretty straightforward so I didn’t think it’d be an issue to wave it in. Since you’re a maintainer, I’ll be more hands-off next time unless I get a ping.

@michalporeba
Copy link
Contributor

Thanks, @BNAndras, I think the grammar fix introduced another grammar issue, but we'll get it resolved with another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants