Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint(track_config): add more checks of exercise slugs #417

Merged
merged 4 commits into from
Sep 8, 2021
Merged

lint(track_config): add more checks of exercise slugs #417

merged 4 commits into from
Sep 8, 2021

Commits on Sep 7, 2021

  1. lint(track_config): add more checks of exercise slugs 

    With this commit, `configlet lint` now checks that a track-level
`config.json` file follows the below rules:

- The `exercises.concept[].slug` value must be unique in
  `exercises.concept[].slug`  and may not exist in
  `exercises.practice[].slug`
- The `exercises.practice[].slug` value must be unique in
  `exercises.practice[].slug` and may not exist in
  `exercises.concept[].slug`
- There must be exactly one `exercises.practice[].slug` value that is
  the string `hello-world`
    @ee7
    ee7 committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    df4d93a View commit details
    Browse the repository at this point in the history

  2. lint(track_config): add foregone check 

    With this commit, `configlet lint` now checks that a track-level
`config.json` file follows the below rule:

- The `exercises.foregone` values must not match any of the concept or
  practice exercise slugs
    @ee7
    ee7 committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    6e46110 View commit details
    Browse the repository at this point in the history

  3. lint(track_config): improve HashSet initial size 

    This signals to the reader that we know the size of the HashSet in
advance.
    @ee7
    ee7 committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    b0dd888 View commit details
    Browse the repository at this point in the history

  4. lint(track_config): prefer tighter parameter 

    This makes it clearer that this proc doesn't use `trackConfig.concepts`.
    @ee7
    ee7 committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    45557f9 View commit details
    Browse the repository at this point in the history