Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint(track_config): fix error for missing track config #429

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

ee7
Copy link
Member

@ee7 ee7 commented Sep 29, 2021

With the most recent configlet release (4.0.0-alpha.31), running
configlet lint using a directory that lacks a config.json file would
produce a segfault (!):

The lint command is under development.
Please re-run this command regularly to see if your track passes the latest linting rules.

Missing file:
/tmp/foo/config.json

SIGSEGV: Illegal storage access. (Attempt to read from nil?)

With this commit, we again get something like (for an empty directory):

The lint command is under development.
Please re-run this command regularly to see if your track passes the latest linting rules.

Missing file:
/tmp/foo/config.json

Missing directory:
/tmp/foo/exercises/shared/.docs

Missing directory:
/tmp/foo/docs

Configlet detected at least one problem.
For more information on resolving the problems, please see the documentation:
https://github.com/exercism/docs/blob/main/building/configlet/lint.md

The problem was introduced by commit e732894, and does not occur in
releases before 4.0.0-alpha.31.

With the most recent configlet release (4.0.0-alpha.31), running
`configlet lint` using a directory that lacks a `config.json` file would
produce:

    The lint command is under development.
    Please re-run this command regularly to see if your track passes the latest linting rules.

    Missing file:
    /tmp/foo/config.json

    SIGSEGV: Illegal storage access. (Attempt to read from nil?)

With this commit, we get:

    The lint command is under development.
    Please re-run this command regularly to see if your track passes the latest linting rules.

    Missing file:
    /tmp/foo/config.json

    Missing directory:
    /tmp/foo/exercises/shared/.docs

    Missing directory:
    /tmp/foo/docs

    Configlet detected at least one problem.
    For more information on resolving the problems, please see the documentation:
    https://github.com/exercism/docs/blob/main/building/configlet/lint.md

The problem was introduced by commit e732894, and does not occur in
releases before 4.0.0-alpha.31.
@ee7 ee7 merged commit 06457bc into exercism:main Oct 5, 2021
@ee7 ee7 deleted the lint-track-config-fix-sigsegv branch October 5, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants