lint(track_config): check hello-world status
#436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "exercises.practice[].status" value must, if "exercises.practice[].slug" is equal to hello-world, be either omitted or the string active Refs: exercism#249
bobtfish
force-pushed
the
more_validation_2
branch
from
6fb67e1
to
5040463
Compare
With the previous wording of:
the value must be [...] `active` or absent
the "value is absent" might be understood as "the value is the empty
string".
This commit tries to clarify, but the wording is a bit clunky. It
doesn't matter much either way, since this error message will probably
be rarely seen.
|
Thanks for working on this. I took the liberty of pushing a few nitpick commits - see the commit messages. Happy for me to merge this, @ErikSchierboom? I probably would've added this in second pass (to avoid pain with working on the |
I agree. Maybe we can move the functionality there later? I'm happy to merge this if you are (I'll leave the honor to you). |
|
This PR causes the following diff to the output of common-lisp+The hello-world Practice Exercise has a `status` of `beta`, but for that exercise, either the value must be `active` or the key/value pair must be omitted (which implies `active`):
+./config.json
+
+Configlet detected at least one problem.
+For more information on resolving the problems, please see the documentation:
+https://github.com/exercism/docs/blob/main/building/configlet/lint.md
red+The hello-world Practice Exercise has a `status` of `beta`, but for that exercise, either the value must be `active` or the key/value pair must be omitted (which implies `active`):
+./config.json
+
+Configlet detected at least one problem.
+For more information on resolving the problems, please see the documentation:
+https://github.com/exercism/docs/blob/main/building/configlet/lint.md
|
|
Nice. |
ee7
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "exercises.practice[].status" value must, if "exercises.practice[].slug" is equal to hello-world, be either omitted or the string active
Refs: #249