lint(exercises): check files.editor field for exercises
#585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows the `hasArrayOfFiles` function to work with optional values.
This commit adds support for linting the `files.editor` field in the `.meta/config.json` file of exercises.
2 tasks
ee7
reviewed
May 5, 2022
| ## Returns true in any of these cases: | ||
| ## - `hasArrayOfStrings` returns true for `data[key]`. | ||
| ## - `data` lacks the key `key` and `isRequired` is false. | ||
| if data.hasKey(key, path, context, isRequired): |
There was a problem hiding this comment.
Do we need this line and extra indendation level? Can we use the below?
if hasArrayOfStrings(data, key, path, context, isRequired = isRequired)There was a problem hiding this comment.
No, because that'll return true if the field is not required and not present, which will cause the subsequent data[key] call to fail.
ee7
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
files.editorfield