Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 4.0.0-beta.6 #645

Merged
merged 1 commit into from
Oct 11, 2022
Merged

release: 4.0.0-beta.6 #645

merged 1 commit into from
Oct 11, 2022

Conversation

ee7
Copy link
Member

@ee7 ee7 commented Aug 4, 2022

Let's create a release, mainly for configlet completion, 1ab75f2 and d5f5485.

The full list of commits that are at least slightly user-facing:

  • d5f5485 sync: allow passing both -uy and --tests include|exclude (#674)
  • 1ab75f2 generate: allow a concept slug to contain digits (#664)
  • f4561b0 github(workflows), nimble: bump Nim from 1.6.6 to 1.6.8 (#666)
  • 5f91265 completions(bash, fish): add zsh completion for -s/--shell (#659)
  • 88046f4 github(workflows): bump macOS from 11 to 12 (#597)
  • 6b6a780 github(workflows): bump Ubuntu from 20.04 to 22.04 (#590)
  • 121b40e completions(fish): remove invalid file completions (#656)
  • e4c8643 completion: add zsh (#653)
  • 1d689ed cli, completion: compress some const strings (#652)
  • 4447bd2 completions: support completion subcommand (#649)
  • 77f7fbf completions: make uuid -n expect an argument (#643)
  • d10dcd6 completion: add configlet completion subcommand (#631)
  • 5d98c51 cli: add missing dot in help message (#644)
  • 690e9e2 completions: add completions for bash and fish (#629)

@ee7 ee7 requested a review from ErikSchierboom as a code owner August 4, 2022 17:25
@ee7 ee7 marked this pull request as draft August 4, 2022 17:28
@ee7
Copy link
Member Author

ee7 commented Aug 18, 2022

@ErikSchierboom Do you think we should do anything more before we merge this?

I think we can merge before finishing #647. Then configlet completion will be available, but fetch-configlet won't tell the user about it yet. I think we can handle updating all the fetch-configlet scripts separately, and that doesn't need to block the release. And changing the fetch-configlet script in this repo doesn't immediately change the script in every track repo - we need to mass PR.

But maybe we should wait until, say, we update the docs in exercism/docs? And this repo?

The best thing might be for configlet to have per-command help (tracked in #103), and then configlet completion --help could print instructions on installing completions. But that isn't going to happen in the immediate future.

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But maybe we should wait until, say, we update the docs in exercism/docs? And this repo?

I think that would probably be wise.

@ee7 ee7 force-pushed the release-4.0.0-beta.6 branch from 12adea5 to fa1148d Compare October 4, 2022 15:11
@ee7
Copy link
Member Author

ee7 commented Oct 11, 2022

Erik agreed last week that we should release.

We should improve the instructions for using configlet completion, but it shouldn't block this release.

As usual, I've checked the change that the release produces to the output of configlet lint and configlet sync -o on every track. No diff, as expected.

Merging soon. Double-checking the release on my fork.

@ee7 ee7 marked this pull request as ready for review October 11, 2022 14:51
@ee7 ee7 merged commit 794e5dd into main Oct 11, 2022
@ee7 ee7 deleted the release-4.0.0-beta.6 branch October 11, 2022 14:58
@ee7
Copy link
Member Author

ee7 commented Oct 11, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants