Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: allow passing both -uy and --tests include|exclude #674

Merged
merged 1 commit into from
Oct 11, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sync/sync.nim
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ proc validate(conf: Conf) =
## Exits with an error message if the given `conf` contains an invalid
## combination of options.
if conf.action.update:
if conf.action.yes and skTests in conf.action.scope:
if conf.action.yes and skTests in conf.action.scope and conf.action.tests == tmChoose:
let msg = fmt"""
'{list(optFmtSyncYes)}' was provided to non-interactively update, but the tests updating mode is still 'choose'.
You can either:
Expand Down