.github, fetch-configlet: rename release assets

[ee7]

Summary:

• Add version string
• Delimit with underscore, not hyphen
• Rename 64bit to x86-64
• Rename 32bit to i386 (note that we do not have 32-bit releases yet anyway)
• Rename tgz to tar.gz
• Rename mac to macos

The configlet release assets have always had architecture-ambiguous names:

configlet-linux-64bit.tgz
configlet-mac-64bit.tgz
configlet-windows-64bit.zip

This naming format is old (added by d4c6e26 in the canonical-data-syncer days), and was ultimately inheirited from:

• the exercism/configlet-v2 releases (https://github.com/exercism/v2-configlet/releases)
• the exercism/cli releases (see Release tarballs are named ambiguously cli#700 (comment) and cli-v3.0.12).

The ambiguous names haven't mattered much so far, because configlet has only released for x86-64. However, I'm getting closer to adding releases for other 64bit architectures, so we finally need to change the names.

For the rationale being the new naming format, see my (hopefully sufficiently exhaustive) bikeshedding in #363 (comment).

Before this commit, the release assets were named like:

configlet-linux-64bit.tgz
configlet-mac-64bit.tgz
configlet-windows-64bit.zip
configlet_4.0.0-beta.7_checksums_sha256.txt

With this commit, the next release will have assets named:

configlet_4.0.0-beta.8_checksums_sha256.txt
configlet_4.0.0-beta.8_linux_x86-64.tar.gz
configlet_4.0.0-beta.8_macos_x86-64.tar.gz
configlet_4.0.0-beta.8_windows_x86-64.zip

where the archive names now match the naming format for the existing checksums file.

Closes: #363
Refs: #24

---

I've tried to convince myself that the naming format with underscores everywhere but architecture and version string (where semver mandates a hyphen):

configlet_4.0.0-beta.7_linux_x86-64.tar.gz

is a better format than hyphens everywhere but architecture:

configlet-4.0.0-beta.7-linux-x86_64.tar.gz

or hyphens everywhere:

configlet-4.0.0-beta.7-linux-x86-64.tar.gz

or underscores everywhere possible:

configlet_4.0.0-beta.7_linux_x86_64.tar.gz

Even though I don't love that:

• It ignores an existing convention that "hyphens separate words, and underscores delimit within a word" (try double clicking on the x86 in x86_64 and x86-64 if you aren't aware of this - the first selects the whole thing, the second doesn't). Note that double-clicking beta in 4.0.0-beta.7 won't select the whole version, and the same is true of 4.0.0_beta.7 even if semver permitted that, so us using underscores everywhere possible doesn't achieve a naming format where double-clicking on part of the name always performs tokenization.
• uname -m returns x86_64, not x86-64. It is still referred to as x86-64 in plenty of other places (e.g. https://en.wikipedia.org/wiki/X86-64)
• If we pretend that prerelease versions don't exist, and applications with more than one word don't exist, I probably prefer:

configlet-4.0.0-linux-x86_64.tar.gz

to this PR's:

configlet_4.0.0_linux_x86-64.tar.gz

---

To allow the fetch-configlet workflow to pass, I have added assets with the new naming format to the configlet 4.0.0-beta.7 release - they're copies of the existing assets, with the same checksums.

Before we create a release that includes this PR, we need to:

• update the fetch-configlet script used by the org-wide configlet workflow.
• and create and merge a PR on every track to update the track-level fetch-configlet{.ps1} scripts. We can do this mass PR either:
  • manually
  • or by adding fetch-configlet to org-wide-files (tracked in consider adding fetch-configlet org-wide-files#262)

But for some period of time, we should keep assets with the old naming format in releases. Then an out-of-date fetch-configlet script will continue to work.

[ErikSchierboom]

With this commit, the next release will have assets named:

Those look good to me.
We can't merge this until we've handled the syncing of the scripts, right?

[ee7]

We can't merge this until we've handled the syncing of the scripts, right?

We can - it's just that we need to manually add assets with the old names before undrafting the release.

I could have made the build workflow automatically upload the duplicate assets, but:

1. I'm hoping we won't go many releases without updating the fetch scripts
2. I think I'd prefer to remove the assets with the old name when the release is no longer the latest one
3. (Partly continuing from point 2), I think I'd prefer for the checksums file to only reference the newly named assets

I'll also remove the newly named assets from 4.0.0-beta.7 after we release 4.0.0-beta.8.

[ErikSchierboom]

Okay sure

[ee7]

@ee7 wrote:

I'll also remove the newly named assets from 4.0.0-beta.7 after we release 4.0.0-beta.8.

Done.

fetch-configlet only ever fetches assets from the latest release. So the point is that every release will eventually only use one archive naming format, with the checksums file referencing only the assets present, with assets uploaded only by GitHub Actions. Rather than the strange looking:

gh release view -R exercism/configlet \
    --json assets \
    --jq '.assets.[] | {updatedAt,name}' \
    | jq

{
  "name": "configlet-linux-64bit.tgz",
  "updatedAt": "2022-10-27T21:00:06Z"
}
{
  "name": "configlet-mac-64bit.tgz",
  "updatedAt": "2022-10-27T21:00:35Z"
}
{
  "name": "configlet-windows-64bit.zip",
  "updatedAt": "2022-10-27T21:01:34Z"
}
{
  "name": "configlet_4.0.0-beta.7_checksums_sha256.txt",
  "updatedAt": "2022-10-27T21:01:50Z"
}
{
  "name": "configlet_4.0.0-beta.7_linux_x86-64.tar.gz",
  "updatedAt": "2022-11-05T15:34:31Z"
}
{
  "name": "configlet_4.0.0-beta.7_macos_x86-64.tar.gz",
  "updatedAt": "2022-11-05T15:34:31Z"
}
{
  "name": "configlet_4.0.0-beta.7_windows_x86-64.zip",
  "updatedAt": "2022-11-05T15:34:31Z"
}