Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: add example minisign output, and clarify #784

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

ee7
Copy link
Member

@ee7 ee7 commented Aug 9, 2023

Part of this was already approved in #557, but I removed it before merging because I didn't want to use a placeholder filename, and wanted this timestamp to match the one from the release.

The wording change from "contains" to "begins with" isn't important. But I guess the previous wording wasn't strictly true: a filename could contain "Signature and comment signature verified".

ee7 added 3 commits August 9, 2023 13:07
I don't think this makes a difference in practice. But I guess the
previous wording wasn't strictly true: maybe a filename could contain
"Signature and comment signature verified".
@ee7 ee7 requested a review from ErikSchierboom as a code owner August 9, 2023 11:10
README.md Show resolved Hide resolved
@ee7 ee7 merged commit 5e6ddd8 into exercism:main Aug 9, 2023
@ee7 ee7 deleted the README-verifying branch August 9, 2023 19:44
@ee7 ee7 changed the title README: add example minisign output, and tweak wording README: add example minisign output, and clarify Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants