Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 4.0.0-beta.18 #856

Merged
merged 1 commit into from
Jan 19, 2024
Merged

release: 4.0.0-beta.18 #856

merged 1 commit into from
Jan 19, 2024

Conversation

ee7
Copy link
Member

@ee7 ee7 commented Jan 19, 2024

Let's create a release for these user-facing commits:

The non-using facing commits are:

  • 4eeb24f refactor: use QuitSuccess and QuitFailure in quit calls (#852)

  • 0d3e407 logger: add withLevel template (#849)


I don't like the descripion of --exercise in:

configlet/README.md

Lines 71 to 76 in 8c3e63e

Options for create:
--approach <slug> The slug of the approach
--article <slug> The slug of the article
--practice-exercise <slug> The slug of the concept exercise
--concept-exercise <slug> The slug of the practice exercise
-e, --exercise <slug> Only operate on this exercise

but I don't think it needs to block release. I'd be really helpful if the release notes for this beta could have example usage for create, though.

@ee7 ee7 merged commit b2ffaf3 into main Jan 19, 2024
13 checks passed
@ee7 ee7 deleted the release-4.0.0-beta.18 branch January 19, 2024 08:24
@ee7
Copy link
Member Author

ee7 commented Jan 19, 2024

@ErikSchierboom I've released this. Good to get this out.

Please check the release notes and edit them as you see fit. It would be great if the examples explained --practice-exercise vs --exercise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants