Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: bump macos-12 to macos-13 #879

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

ee7
Copy link
Member

@ee7 ee7 commented Jul 10, 2024

This is the newer x86_64 macOS image, and is not in beta. See here.

It would be possible to use macos-14 somewhere, building a macOS arm64 configlet asset natively rather than cross-compiling via Zig. But let's not consider that in this PR.


To-do:

  • Resolve error in the build workflow, in particular the cross-compile job for aarch64-macos-none
CC: ../nimdir/lib/std/sysrand.nim
/Users/runner/.cache/nim/configlet_r/@m..@snimdir@slib@sstd@ssysrand.nim.c:9:10: fatal error: 'Security/SecRandom.h' file not found
nimble.nim(304)          buildFromDir
    9 | #include <Security/SecRandom.h>

      |          ^~~~~~~~~~~~~~~~~~~~~~
    Error:  Build failed for the package: configlet
1 error generated.
     Info:  Nimble data file "/Users/runner/.nimble/nimbledata2.json" has been saved.
Error: execution of an external compiler program 'zigcc -c -w -ferror-limit=3 -pthread -target aarch64-macos-none -Os   -I/Users/runner/work/exercism-configlet/exercism-configlet/nimdir/lib -I/Users/runner/work/exercism-configlet/exercism-configlet/src -o /Users/runner/.cache/nim/configlet_r/@m..@snimdir@slib@sstd@ssysrand.nim.c.o /Users/runner/.cache/nim/configlet_r/@m..@snimdir@slib@sstd@ssysrand.nim.c' failed with exit code: 1

I think it just needs to pass to the linker:

-framework Security

@ee7 ee7 marked this pull request as ready for review July 11, 2024 05:55
@ee7 ee7 requested a review from ErikSchierboom as a code owner July 11, 2024 05:55
@ee7 ee7 marked this pull request as draft July 11, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants