Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update triangle tests #787

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Conversation

DebbieSan
Copy link
Contributor

Hello,

I followed the guide to synch and update the tests for the triangle exercise. I am not sure if there is another part to this process. If yes, please advise.

Thank you kindly!

Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jan 28, 2024
@DebbieSan DebbieSan mentioned this pull request Jan 28, 2024
21 tasks
@IsaacG IsaacG reopened this Jan 28, 2024
@vaeng
Copy link
Contributor

vaeng commented Mar 12, 2024

Would you be so kind and add the uuids from the toml file to the tests and change the names of the cpp test files so they match the toml file as well?
Here is an example:
https://github.com/exercism/cpp/blob/main/exercises/practice/allergies/allergies_test.cpp

I can do it, if you don't want to spend more time on this. I know it can be exhausting to change so many things one by one.

@DebbieSan
Copy link
Contributor Author

DebbieSan commented Mar 15, 2024

hi @vaeng for sure, I will do it :) thank you.

@DebbieSan
Copy link
Contributor Author

Hi @vaeng, I added the UUIDs and updated the names, a couple of the tests I was unsure as they did not seem to match the toml file. Please advise and thank you kindly for your assistance.

DebbieSan and others added 2 commits March 15, 2024 10:37
The person who submitted the pr mixed some UUIDs and had tests doubled.

Also some tests had to be excluded for this tracks, as they did not work with the chosen implementation.
@vaeng
Copy link
Contributor

vaeng commented Oct 8, 2024

Hello @DebbieSan,

please excuse my commit, it is a complete rework of your submission. I hope you are okay with this.
There were a bunch of smaller issues (forgotten brackets, quotes, doubled UUIDS, and some other smaller things), and pointing out all them would be more work for both of us than just correcting them.

Also, I could not get the actions to trigger a check, so I used a commit to run them. Now we can see the check.

A bigger issue was that the tests as they are specified in the problem spec, are not completely compatible with the way the exercise solution is set up on this track. I had to mark them disabled and removedthem from the test file.

I hope you are okay with this. It took a long time for me to come back to you, but you will still get your exercism reputation points. Better late than never. I also threw in the hacktoberfest-contribution so you have a small jump-start from the past to continue your open-source progress.

Thanks for all the work and your patience.

@vaeng vaeng added x:action/sync Sync content with its latest version hacktoberfest-accepted labels Oct 8, 2024
Copy link
Contributor

@vaeng vaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[no important files changed]

@vaeng vaeng merged commit 144f347 into exercism:main Oct 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/sync Sync content with its latest version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants