[New Concept & Exercise]: Iteration #627

meatball133 · 2024-04-21T07:15:30Z

No description provided.

ErikSchierboom · 2024-05-23T07:56:33Z

exercises/concept/spellbound-steel/.docs/introduction.md

I feel like this might be introducing too much. It's not just iteration, it's also introducing:

present?, empty?, any?, all?, none?, one?

count

sort_by

I would have expected this exercise to be about each and times and possibly map and reduce.

…k and expanded some content

ryanplusplus · 2024-06-01T11:52:00Z

concepts/iteration/about.md

+Both the `Array` and `Range` classes in Crystal include the [`Enumerable`][enumerable] module, which provides a number of methods for iterating over the elements.
+Meanwhile, the `String` class has its own set of methods for iterating over the characters.
+
+Crystal also doesnt have any any for statement like other languages.


Suggested change

Crystal also doesnt have any any for statement like other languages.

Crystal also doesn't have any for statement like other languages.

ryanplusplus · 2024-06-01T11:52:29Z

concepts/iteration/about.md

+
+The most common way to iterate over a collection is to use the [`each`][each] method, which yields each element in the collection to a block.
+This can be done easily with a `Range`.
+Say you would want to loop between 1 and 3, you can use the `each` method to iterate over the range.


Suggested change

Say you would want to loop between 1 and 3, you can use the `each` method to iterate over the range.

Say you want to loop between 1 and 3, you can use the `each` method to iterate over the range.

ryanplusplus · 2024-06-01T11:53:07Z

concepts/iteration/about.md

+# 3
+```
+
+Even simplier if you just want to iterate n numbers of times you can use the [`times`][times] method, which exists on the `Int` class.


Suggested change

Even simplier if you just want to iterate n numbers of times you can use the [`times`][times] method, which exists on the `Int` class.

Even simpler, if you just want to iterate a number of times you can use the [`times`][times] method, which exists on the `Int` class.

ryanplusplus · 2024-06-01T11:53:29Z

concepts/iteration/about.md

+
+## Iterating over a `String`
+
+A `String` is a sequence of characters, and doesnt belong to the `Enumerable` module, which means it has its own set of methods for iterating over the characters.


Suggested change

A `String` is a sequence of characters, and doesnt belong to the `Enumerable` module, which means it has its own set of methods for iterating over the characters.

A `String` is a sequence of characters and doesn't belong to the `Enumerable` module, which means it has its own set of methods for iterating over the characters.

ryanplusplus · 2024-06-01T11:53:56Z

concepts/iteration/about.md

+# o
+```
+
+Another way of iterating over a `String` is to use the [`each_line`][each_line] method, this method is mostly used when reading a file line by line.


Suggested change

Another way of iterating over a `String` is to use the [`each_line`][each_line] method, this method is mostly used when reading a file line by line.

Another way of iterating over a `String` is to use the [`each_line`][each_line] method.

This method is mostly used when reading a file line by line.

ryanplusplus · 2024-06-01T12:20:07Z

exercises/concept/spellbound-steel/spec/spellbound_steel_spec.cr

+      SpellboundSteel.calculate_power_level(deck).should eq(35)
+    end
+
+    it "should return 65 if the deck has a Rogue and Ice Storm " do


Suggested change

it "should return 65 if the deck has a Rogue and Ice Storm " do

it "should return 65 if the deck has a Rogue and an Ice Storm " do

ryanplusplus · 2024-06-01T12:20:24Z

exercises/concept/spellbound-steel/spec/spellbound_steel_spec.cr

+      SpellboundSteel.decode_characters("").should eq("")
+    end
+
+    it "should return warrior if the inut is wbalrrrlimoqr" do


Suggested change

it "should return warrior if the inut is wbalrrrlimoqr" do

it "should return warrior if the input is wbalrrrlimoqr" do

ryanplusplus · 2024-06-01T12:20:39Z

exercises/concept/spellbound-steel/spec/spellbound_steel_spec.cr

+      SpellboundSteel.decode_characters("wbalrrrlimoqr").should eq("warrior")
+    end
+
+    it "should return mage if the inut is mlabgle" do


Suggested change

it "should return mage if the inut is mlabgle" do

it "should return mage if the input is mlabgle" do

ryanplusplus · 2024-06-01T12:21:13Z

exercises/concept/spellbound-steel/spec/spellbound_steel_spec.cr

+      SpellboundSteel.decode_characters("mlabgle").should eq("mage")
+    end
+
+    it "should return rogue if the inut is rloguqgle" do


Suggested change

it "should return rogue if the inut is rloguqgle" do

it "should return rogue if the input is rloggquge" do

ryanplusplus · 2024-06-01T12:22:08Z

exercises/concept/spellbound-steel/src/spellbound_steel.cr

+  def self.sort_cards_by_power_level(characters)
+    raise "Please implement the SpellboundSteel.sort_cards_by_power_level method"
+  end
+


Suggested change

def self.sort_cards_by_power_level(characters)

raise "Please implement the SpellboundSteel.sort_cards_by_power_level method"

end

meatball133 added 4 commits April 19, 2024 21:29

Add iteration concept and spellbound-steel exercise

49c4cf9

More work

957d592

Finnish draft

d17f038

Fixes to configlet, fixes to exercise

b8599e6

meatball133 marked this pull request as ready for review May 18, 2024 15:29

Fix solution

517ef30

meatball133 requested a review from ErikSchierboom May 23, 2024 07:38

ErikSchierboom reviewed May 23, 2024

View reviewed changes

Fixes and improvments and removed some content mentioned from feedbac…

3a4a938

…k and expanded some content

ryanplusplus requested changes Jun 1, 2024

View reviewed changes

Update based on feedback

5ed1c57

ryanplusplus approved these changes Jul 17, 2024

View reviewed changes

ryanplusplus merged commit c15a60c into exercism:main Jul 17, 2024
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[New Concept & Exercise]: Iteration #627

[New Concept & Exercise]: Iteration #627

meatball133 commented Apr 21, 2024

ErikSchierboom May 23, 2024

ryanplusplus Jun 1, 2024

ryanplusplus Jun 1, 2024

ryanplusplus Jun 1, 2024

ryanplusplus Jun 1, 2024

ryanplusplus Jun 1, 2024

ryanplusplus Jun 1, 2024

ryanplusplus Jun 1, 2024

ryanplusplus Jun 1, 2024

ryanplusplus Jun 1, 2024

ryanplusplus Jun 1, 2024

	Crystal also doesnt have any any for statement like other languages.
	Crystal also doesn't have any for statement like other languages.

	Say you would want to loop between 1 and 3, you can use the `each` method to iterate over the range.
	Say you want to loop between 1 and 3, you can use the `each` method to iterate over the range.

	Even simplier if you just want to iterate n numbers of times you can use the [`times`][times] method, which exists on the `Int` class.
	Even simpler, if you just want to iterate a number of times you can use the [`times`][times] method, which exists on the `Int` class.


		## Iterating over a `String`

		A `String` is a sequence of characters, and doesnt belong to the `Enumerable` module, which means it has its own set of methods for iterating over the characters.

	A `String` is a sequence of characters, and doesnt belong to the `Enumerable` module, which means it has its own set of methods for iterating over the characters.
	A `String` is a sequence of characters and doesn't belong to the `Enumerable` module, which means it has its own set of methods for iterating over the characters.

	Another way of iterating over a `String` is to use the [`each_line`][each_line] method, this method is mostly used when reading a file line by line.
	Another way of iterating over a `String` is to use the [`each_line`][each_line] method.
	This method is mostly used when reading a file line by line.

	it "should return 65 if the deck has a Rogue and Ice Storm " do
	it "should return 65 if the deck has a Rogue and an Ice Storm " do

	it "should return warrior if the inut is wbalrrrlimoqr" do
	it "should return warrior if the input is wbalrrrlimoqr" do

	it "should return mage if the inut is mlabgle" do
	it "should return mage if the input is mlabgle" do

	it "should return rogue if the inut is rloguqgle" do
	it "should return rogue if the input is rloggquge" do

	def self.sort_cards_by_power_level(characters)
	raise "Please implement the SpellboundSteel.sort_cards_by_power_level method"
	end

[New Concept & Exercise]: Iteration #627

[New Concept & Exercise]: Iteration #627

Conversation

meatball133 commented Apr 21, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment