Support more tags and some fixes (#245)

* Add modulo and integer assignment expressions * Add modulo operator * Add more tags
exercism · Nov 8, 2023 · ec15781 · ec15781
1 parent 5c94b3c
commit ec15781
Show file tree

Hide file tree

Showing 78 changed files with 734 additions and 45 deletions.
diff --git a/src/Exercism.Analyzers.CSharp/Analysis.cs b/src/Exercism.Analyzers.CSharp/Analysis.cs
@@ -110,6 +110,7 @@ public static IEnumerable<Analyzer> CreateAnalyzers(Submission submission)
     protected string GetDeclaredSymbolName(SyntaxNode node) => GetDeclaredSymbol(node)?.ToDisplayString();
 
     protected TypeInfo GetTypeInfo(SyntaxNode node) => _semanticModel.GetTypeInfo(node);
+    protected IOperation GetOperation(SyntaxNode node) => _semanticModel.GetOperation(node);
 
     protected IMethodSymbol GetConstructedFromSymbol(SyntaxNode node) =>
         GetSymbol(node) is IMethodSymbol methodSymbol ? methodSymbol.ConstructedFrom : null;

diff --git a/src/Exercism.Analyzers.CSharp/Analyzers/TagAnalyzer.cs b/src/Exercism.Analyzers.CSharp/Analyzers/TagAnalyzer.cs
diff --git a/tests/bank-account/approaches/lock-statement/expected_tags.json b/tests/bank-account/approaches/lock-statement/expected_tags.json
@@ -1,5 +1,7 @@
 {
   "tags": [
+    "construct:add",
+    "construct:add-assignment",
     "construct:assignment",
     "construct:boolean",
     "construct:class",
@@ -9,7 +11,9 @@
     "construct:field",
     "construct:floating-point-number",
     "construct:if",
+    "construct:implicit-object-creation",
     "construct:lock",
+    "construct:logical-not",
     "construct:method",
     "construct:parameter",
     "construct:property",
@@ -23,6 +27,7 @@
     "construct:visibility-modifiers",
     "paradigm:imperative",
     "paradigm:object-oriented",
+    "technique:compound-assignment",
     "technique:exceptions",
     "technique:locks"
   ]

diff --git a/tests/bank-account/approaches/mutex/expected_tags.json b/tests/bank-account/approaches/mutex/expected_tags.json
@@ -1,5 +1,7 @@
 {
   "tags": [
+    "construct:add",
+    "construct:add-assignment",
     "construct:assignment",
     "construct:boolean",
     "construct:class",
@@ -10,7 +12,9 @@
     "construct:finally",
     "construct:floating-point-number",
     "construct:if",
+    "construct:implicit-object-creation",
     "construct:invocation",
+    "construct:logical-not",
     "construct:method",
     "construct:parameter",
     "construct:property",
@@ -25,6 +29,7 @@
     "construct:visibility-modifiers",
     "paradigm:imperative",
     "paradigm:object-oriented",
+    "technique:compound-assignment",
     "technique:exceptions",
     "technique:mutexes",
     "uses:Mutex"

diff --git a/tests/bob/approaches/answer-array/expected_tags.json b/tests/bob/approaches/answer-array/expected_tags.json
@@ -4,6 +4,7 @@
     "construct:boolean",
     "construct:char",
     "construct:class",
+    "construct:equality",
     "construct:field",
     "construct:if",
     "construct:implicit-conversion",
@@ -28,6 +29,7 @@
     "paradigm:functional",
     "paradigm:object-oriented",
     "technique:boolean-logic",
-    "technique:higher-order-functions"
+    "technique:higher-order-functions",
+    "technique:short-circuiting"
   ]
 }
diff --git a/tests/bob/approaches/if/expected_tags.json b/tests/bob/approaches/if/expected_tags.json
@@ -3,6 +3,7 @@
     "construct:boolean",
     "construct:char",
     "construct:class",
+    "construct:equality",
     "construct:if",
     "construct:implicit-conversion",
     "construct:invocation",
@@ -18,6 +19,7 @@
     "paradigm:functional",
     "paradigm:object-oriented",
     "technique:boolean-logic",
-    "technique:higher-order-functions"
+    "technique:higher-order-functions",
+    "technique:short-circuiting"
   ]
 }
diff --git a/tests/bob/approaches/regular-expressions/expected_tags.json b/tests/bob/approaches/regular-expressions/expected_tags.json
@@ -15,6 +15,7 @@
     "paradigm:object-oriented",
     "technique:boolean-logic",
     "technique:regular-expression",
+    "technique:short-circuiting",
     "uses:Regex"
   ]
 }
diff --git a/tests/bob/approaches/switch-on-tuple/expected_tags.json b/tests/bob/approaches/switch-on-tuple/expected_tags.json
@@ -3,6 +3,7 @@
     "construct:boolean",
     "construct:char",
     "construct:class",
+    "construct:equality",
     "construct:expression-bodied-member",
     "construct:if",
     "construct:implicit-conversion",
@@ -23,6 +24,7 @@
     "paradigm:object-oriented",
     "technique:boolean-logic",
     "technique:higher-order-functions",
+    "technique:short-circuiting",
     "uses:ValueTuple"
   ]
 }
diff --git a/tests/collatz-conjecture/approaches/recursion/expected_tags.json b/tests/collatz-conjecture/approaches/recursion/expected_tags.json
@@ -4,14 +4,17 @@
     "construct:class",
     "construct:constructor",
     "construct:divide",
+    "construct:equality",
     "construct:if",
     "construct:int",
     "construct:integral-number",
     "construct:invocation",
     "construct:lambda",
     "construct:method",
     "construct:method-overloading",
+    "construct:modulo",
     "construct:multiply",
+    "construct:nameof",
     "construct:number",
     "construct:parameter",
     "construct:return",

diff --git a/tests/collatz-conjecture/approaches/sequence/expected_tags.json b/tests/collatz-conjecture/approaches/sequence/expected_tags.json
@@ -5,13 +5,17 @@
     "construct:class",
     "construct:constructor",
     "construct:divide",
+    "construct:equality",
     "construct:if",
+    "construct:inequality",
     "construct:int",
     "construct:integral-number",
     "construct:invocation",
     "construct:linq",
     "construct:method",
+    "construct:modulo",
     "construct:multiply",
+    "construct:nameof",
     "construct:number",
     "construct:parameter",
     "construct:return",

diff --git a/tests/collatz-conjecture/approaches/while-loop/expected_tags.json b/tests/collatz-conjecture/approaches/while-loop/expected_tags.json
@@ -5,14 +5,19 @@
     "construct:class",
     "construct:constructor",
     "construct:divide",
+    "construct:equality",
     "construct:if",
+    "construct:inequality",
     "construct:int",
     "construct:integral-number",
     "construct:invocation",
     "construct:method",
+    "construct:modulo",
     "construct:multiply",
+    "construct:nameof",
     "construct:number",
     "construct:parameter",
+    "construct:postfix-increment",
     "construct:return",
     "construct:throw",
     "construct:using-directive",

diff --git a/tests/difference-of-squares/approaches/for-statement/expected_tags.json b/tests/difference-of-squares/approaches/for-statement/expected_tags.json
@@ -1,5 +1,7 @@
 {
   "tags": [
+    "construct:add",
+    "construct:add-assignment",
     "construct:assignment",
     "construct:class",
     "construct:expression-bodied-member",
@@ -11,12 +13,14 @@
     "construct:multiply",
     "construct:number",
     "construct:parameter",
+    "construct:postfix-increment",
     "construct:return",
     "construct:subtract",
     "construct:variable",
     "construct:visibility-modifiers",
     "paradigm:imperative",
     "paradigm:object-oriented",
+    "technique:compound-assignment",
     "technique:looping",
     "technique:math"
   ]

diff --git a/tests/diffie-hellman/approaches/big-integer/expected_tags.json b/tests/diffie-hellman/approaches/big-integer/expected_tags.json
@@ -5,6 +5,7 @@
     "construct:explicit-conversion",
     "construct:expression-bodied-member",
     "construct:implicit-conversion",
+    "construct:implicit-object-creation",
     "construct:integral-number",
     "construct:invocation",
     "construct:lambda",

diff --git a/tests/grade-school/approaches/sorted-collections/expected_tags.json b/tests/grade-school/approaches/sorted-collections/expected_tags.json
@@ -9,11 +9,13 @@
     "construct:field",
     "construct:if",
     "construct:implicit-conversion",
+    "construct:implicit-object-creation",
     "construct:indexer",
     "construct:initializer",
     "construct:invocation",
     "construct:lambda",
     "construct:linq",
+    "construct:logical-not",
     "construct:method",
     "construct:parameter",
     "construct:read-only",

diff --git a/tests/grains/approaches/bit-shifting/expected_tags.json b/tests/grains/approaches/bit-shifting/expected_tags.json
@@ -25,6 +25,7 @@
     "technique:bit-shifting",
     "technique:boolean-logic",
     "technique:exceptions",
+    "technique:short-circuiting",
     "technique:type-conversion"
   ]
 }
diff --git a/tests/grains/approaches/max-value/expected_tags.json b/tests/grains/approaches/max-value/expected_tags.json
@@ -12,6 +12,7 @@
     "construct:is-cast",
     "construct:lambda",
     "construct:method",
+    "construct:nameof",
     "construct:number",
     "construct:parameter",
     "construct:pattern-matching",

diff --git a/tests/grains/approaches/pow/expected_tags.json b/tests/grains/approaches/pow/expected_tags.json
@@ -13,6 +13,7 @@
     "construct:lambda",
     "construct:linq",
     "construct:method",
+    "construct:nameof",
     "construct:number",
     "construct:parameter",
     "construct:pattern-matching",

diff --git a/tests/hamming/approaches/for-loop/expected_tags.json b/tests/hamming/approaches/for-loop/expected_tags.json
@@ -5,11 +5,13 @@
     "construct:for-loop",
     "construct:if",
     "construct:indexer",
+    "construct:inequality",
     "construct:int",
     "construct:integral-number",
     "construct:method",
     "construct:number",
     "construct:parameter",
+    "construct:postfix-increment",
     "construct:return",
     "construct:string",
     "construct:throw",

diff --git a/tests/hamming/approaches/linq/expected_tags.json b/tests/hamming/approaches/linq/expected_tags.json
@@ -4,6 +4,7 @@
     "construct:constructor",
     "construct:if",
     "construct:implicit-conversion",
+    "construct:inequality",
     "construct:invocation",
     "construct:lambda",
     "construct:linq",

diff --git a/tests/isogram/approaches/bitfield/expected_tags.json b/tests/isogram/approaches/bitfield/expected_tags.json
@@ -2,11 +2,14 @@
   "tags": [
     "construct:assignment",
     "construct:bitwise-and",
+    "construct:bitwise-or",
+    "construct:bitwise-or-assignment",
     "construct:boolean",
     "construct:class",
     "construct:foreach",
     "construct:if",
     "construct:implicit-conversion",
+    "construct:inequality",
     "construct:int",
     "construct:integral-number",
     "construct:left-shift",
@@ -23,7 +26,9 @@
     "technique:bit-manipulation",
     "technique:bit-shifting",
     "technique:boolean-logic",
+    "technique:compound-assignment",
     "technique:enumeration",
-    "technique:looping"
+    "technique:looping",
+    "technique:short-circuiting"
   ]
 }
diff --git a/tests/isogram/approaches/distinct/expected_tags.json b/tests/isogram/approaches/distinct/expected_tags.json
@@ -2,6 +2,7 @@
   "tags": [
     "construct:char",
     "construct:class",
+    "construct:equality",
     "construct:implicit-conversion",
     "construct:invocation",
     "construct:lambda",

diff --git a/tests/isogram/approaches/groupby/expected_tags.json b/tests/isogram/approaches/groupby/expected_tags.json
@@ -2,6 +2,7 @@
   "tags": [
     "construct:char",
     "construct:class",
+    "construct:equality",
     "construct:implicit-conversion",
     "construct:int",
     "construct:integral-number",

diff --git a/tests/leap/approaches/boolean-chain/expected_tags.json b/tests/leap/approaches/boolean-chain/expected_tags.json
@@ -2,16 +2,20 @@
   "tags": [
     "construct:boolean",
     "construct:class",
+    "construct:equality",
+    "construct:inequality",
     "construct:int",
     "construct:integral-number",
     "construct:logical-and",
     "construct:logical-or",
     "construct:method",
+    "construct:modulo",
     "construct:number",
     "construct:parameter",
     "construct:return",
     "construct:visibility-modifiers",
     "paradigm:object-oriented",
-    "technique:boolean-logic"
+    "technique:boolean-logic",
+    "technique:short-circuiting"
   ]
 }
diff --git a/tests/leap/approaches/datetime-addition/expected_tags.json b/tests/leap/approaches/datetime-addition/expected_tags.json
@@ -4,6 +4,7 @@
     "construct:constructor",
     "construct:date-time",
     "construct:double",
+    "construct:equality",
     "construct:expression-bodied-member",
     "construct:floating-point-number",
     "construct:int",

diff --git a/tests/leap/approaches/switch-on-a-tuple/expected_tags.json b/tests/leap/approaches/switch-on-a-tuple/expected_tags.json
@@ -6,6 +6,7 @@
     "construct:integral-number",
     "construct:lambda",
     "construct:method",
+    "construct:modulo",
     "construct:number",
     "construct:parameter",
     "construct:pattern-matching",

diff --git a/tests/leap/approaches/ternary-operator/expected_tags.json b/tests/leap/approaches/ternary-operator/expected_tags.json
@@ -1,9 +1,11 @@
 {
   "tags": [
     "construct:class",
+    "construct:equality",
     "construct:int",
     "construct:integral-number",
     "construct:method",
+    "construct:modulo",
     "construct:number",
     "construct:parameter",
     "construct:return",

diff --git a/tests/leap/if-statements/expected_tags.json b/tests/leap/if-statements/expected_tags.json
@@ -2,16 +2,20 @@
   "tags": [
     "construct:boolean",
     "construct:class",
+    "construct:equality",
     "construct:if",
+    "construct:inequality",
     "construct:int",
     "construct:integral-number",
     "construct:logical-or",
     "construct:method",
+    "construct:modulo",
     "construct:number",
     "construct:parameter",
     "construct:return",
     "construct:visibility-modifiers",
     "paradigm:object-oriented",
-    "technique:boolean-logic"
+    "technique:boolean-logic",
+    "technique:short-circuiting"
   ]
 }
diff --git a/tests/leap/nested-if-statement/expected_tags.json b/tests/leap/nested-if-statement/expected_tags.json
@@ -2,10 +2,13 @@
   "tags": [
     "construct:boolean",
     "construct:class",
+    "construct:equality",
     "construct:if",
+    "construct:inequality",
     "construct:int",
     "construct:integral-number",
     "construct:method",
+    "construct:modulo",
     "construct:number",
     "construct:parameter",
     "construct:return",