Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add practice and prerequisites - 2 #1511

Merged
merged 4 commits into from
Mar 3, 2021
Merged

add practice and prerequisites - 2 #1511

merged 4 commits into from
Mar 3, 2021

Conversation

valentin-p
Copy link
Contributor

ErikSchierboom
ErikSchierboom reviewed Mar 2, 2021
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! I've left a comment, but once that is fixed, this is ready to merge! Thanks!

@valentin-p
Copy link
Contributor Author

I could not find the comment.

@ErikSchierboom
Copy link
Member

Weird, I'll re-add it.

@ErikSchierboom
Copy link
Member

@valentin-p Done

@valentin-p
Copy link
Contributor Author

Updated.

@ErikSchierboom
Copy link
Member

@valentin-p Great, but the other exercises should be updated too :)

@valentin-p
Copy link
Contributor Author

Sure. added all practices as prerequisites too

ErikSchierboom
ErikSchierboom approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! As a side note: it is entirely possible that the practices key contains values that are not in the prerequisites key. I've even suggested to examples where that is the case :)

@valentin-p valentin-p merged commit a27e910 into exercism:main Mar 3, 2021
@valentin-p valentin-p deleted the practice-config-prerequisites branch March 3, 2021 08:52
@ErikSchierboom
Copy link
Member

Awesome work! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

@mikedamay mikedamay Awaiting requested review from mikedamay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentin-p @ErikSchierboom