Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General correction of language, style, and wrong links #436

Merged
merged 5 commits into from
Apr 28, 2023

Conversation

safwansamsudeen
Copy link
Contributor

@ErikSchierboom, I've corrected many stylistic and linguistic errors in the Building directory of the docs. This is in relation to the Errors in Exercism docs issue on the Forum.

There is much more improvement left to be done both in this directory and outside of it, and I'll continue to work on this and open more pull requests: please do let me know if you want multiple commits in one PR or separate PRs. I'll ask on issues I'm doubtful on in the Forum question, not here.

Thanks for your time!

@github-actions
Copy link

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Mar 19, 2023
building/github/contributors-pull-request-guide.md Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@ErikSchierboom
Copy link
Member

As a side note: the PR title has an "and" in it, which implies that it is doing multiple things. For future PRs I would recommend opening several smaller PRs that each do one thing (one for fixing links, one for grammar, etc.)

building/github/gha-best-practices.md Outdated Show resolved Hide resolved
building/github/gha-best-practices.md Outdated Show resolved Hide resolved
building/configlet/lint.md Show resolved Hide resolved
building/configlet/lint.md Outdated Show resolved Hide resolved
building/configlet/lint.md Outdated Show resolved Hide resolved
@safwansamsudeen
Copy link
Contributor Author

As a side note: the PR title has an "and" in it, which implies that it is doing multiple things. For future PRs I would recommend opening several smaller PRs that each do one thing (one for fixing links, one for grammar, etc.)

Sure, Eric, I'll keep that in mind next time!

@ErikSchierboom
Copy link
Member

Looks good. @ee7 what do you think?

@safwansamsudeen safwansamsudeen requested a review from ee7 April 4, 2023 12:29
Copy link
Member

@ee7 ee7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after these small changes. Sorry for the slow review.

.gitignore Outdated Show resolved Hide resolved
building/github/contributors-pull-request-guide.md Outdated Show resolved Hide resolved
building/configlet/lint.md Outdated Show resolved Hide resolved
@safwansamsudeen
Copy link
Contributor Author

Any update on this, folks?

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last suggestion.

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
@ErikSchierboom ErikSchierboom merged commit c9b1c13 into exercism:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants