Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated meetup instructions #1212

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Updated meetup instructions #1212

merged 2 commits into from
Oct 6, 2022

Conversation

tradfursten
Copy link
Contributor

No description provided.

@tradfursten
Copy link
Contributor Author

It is possible to add the hacktoberfest-accepted label?

@jiegillet
Copy link
Contributor

It is possible to add the hacktoberfest-accepted label?

Hi @tradfursten!
Sure, we can add that label, but I feel that it is worthy of a tiny bit more effort 😇
I see from running bin/configlet sync that we are missing a test case for matching-brackets, would you consider doing that too in this PR? The instructions are here.

@tradfursten
Copy link
Contributor Author

I'll fix the tests :)
I thought I was suppose to have one pr per thing I fixed :)

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps

    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)
  • Any exercise changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <exercise>/.meta/config.json (see docs)?
    • 🔬 Do the analyzer and the analyzer comments exist for this exercise? Do they need to be changed?
    • 📜 Does the design file (<exercise>/.meta/design.md) need to be updated to document new implementation decisions?
  • Practice exercise changed

    • 🌲 Do prerequisites, practices, and difficulty in config.json need to be updated?
    • 🧑‍🏫 Are the changes in accordance with the community-wide problem specifiations?
  • Practice exercise tests changed

    • ⚪️ Are all tests except the first one skipped?
    • 📜 Does <exercise>/.meta/tests.toml need updating?

Automated comment created by PR Commenter 🤖.

Copy link
Contributor

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I was suppose to have one pr per thing I fixed :)

Well, generally yes, but I do have the bandwidth to handle a +9/-1 PR :)

Thank you!

@jiegillet jiegillet added canonical sync 🔄 For issues/changes related to synchronization between test suites and the canonical data x:size/small Small amount of work hacktoberfest-accepted labels Oct 6, 2022
@jiegillet jiegillet merged commit dbb9f91 into exercism:main Oct 6, 2022
@jiegillet
Copy link
Contributor

jiegillet commented Oct 7, 2022

@tradfursten there was just a big batch of problem-specs updates, if you want another label :)

@tradfursten
Copy link
Contributor Author

@tradfursten there was just a big batch of problem-specs updates, if you want another label :)

Nice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canonical sync 🔄 For issues/changes related to synchronization between test suites and the canonical data x:size/small Small amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants