Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ELIXIR:community-garden add new test to Task4 #1346

Merged

Conversation

zulkris
Copy link
Contributor

@zulkris zulkris commented Aug 3, 2023

there are no necessary test for https://exercism.org/tracks/elixir/exercises/community-garden/ which checking the using plot_id param really used in release function

f.e. current code works well (no tests fails)

  def release(pid, _plot_id) do
    %{next_id: next_id} = Agent.get(pid, & &1)
    Agent.update(pid, fn %{next_id: next_id} -> %{plots: [], next_id: next_id} end)
  end

This PR adds new test to check this

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps

    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)
  • Any exercise changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <exercise>/.meta/config.json (see docs)?
    • 🔬 Do the analyzer and the analyzer comments exist for this exercise? Do they need to be changed?
    • 📜 Does the design file (<exercise>/.meta/design.md) need to be updated to document new implementation decisions?
  • Concept exercise changed

    • 🌲 Do prerequisites and practices in config.json need to be updated?
    • 📖 Does the concept introduction provide all necessary information to solve this exercise?
  • Concept exercise tests changed

    • ⚪️ Are all tests un-skipped?
    • 🔢 Are all tests annotated with @tag task_id?
    • 🐈 Can all tests be understood by reading the test's block only (e.g. no module attributes, no setup functions)?

Automated comment created by PR Commenter 🤖.

@zulkris zulkris changed the title ELIXIR:community-garden add new test to Task4 ELIXIR:community-garden add new test to Task4 x:rep/medium Aug 3, 2023
@zulkris zulkris changed the title ELIXIR:community-garden add new test to Task4 x:rep/medium ELIXIR:community-garden add new test to Task4 Aug 3, 2023
Copy link
Contributor

@angelikatyborska angelikatyborska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! That was a terrible oversight from our side, thank you for fixing it 🙂

@angelikatyborska angelikatyborska merged commit 3e9493b into exercism:main Aug 4, 2023
@zulkris zulkris deleted the ELIXIR_community-garden_add_test branch August 7, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants