-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the disable comments for the markdown formatter #1493
fix the disable comments for the markdown formatter #1493
Conversation
According to docs these comments should look like this. Hopefully this will prevent them from showing up on the exercism page e.g. https://exercism.org/tracks/elixir/exercises/rpn-calculator in the section "Try/Rescue" See: https://hexdocs.pm/markdown_code_block_formatter/readme.html#disabling-the-formatter-for-specific-code-blocks
Thank you for contributing to Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:
Automated comment created by PR Commenter 🤖. |
Ooops, I didn't notice that they actually show up on the website 🙈 If we change them from @ErikSchierboom can you advise, why do empty links without an url show up on the website? E.g. https://exercism.org/tracks/elixir/exercises/leap/approaches/operators |
It looks like that is the default behavior of our markdown library |
So should we remove the comments altogether then? Or do you think it feasable to keep them and make them work like intended. Maybe some option in the markdown library / configlet or something. |
I'm positive there isn't such an option available. We could manually override the default behavior, although I'm not sure that is possible. @iHiD what do you think? |
We'll have to live with forced autoformatting in concept introductions 🤷 it's not the worst thing ever. I pushed one commit that updates that one code snippet that was resisting formatting before. @DerMolly thank you for bringing this issue to our attention 🙏 |
According to docs these comments should look like this. Hopefully this will prevent them from showing up on the exercism page e.g. https://exercism.org/tracks/elixir/exercises/rpn-calculator in the section "Try/Rescue"
See:
https://hexdocs.pm/markdown_code_block_formatter/readme.html#disabling-the-formatter-for-specific-code-blocks