Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Typos in Instructions of Pig Latin #1510

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

Lasamat
Copy link
Contributor

@Lasamat Lasamat commented Aug 7, 2024

Fixed 2 typos in Pig-Latin.
I checked with Problem Specifications and although they differ generally by wording the typos are not in that one.

I don't know if they are supposed to be identical but they are not and I would atleast like to fix the typos.

Copy link
Contributor

github-actions bot commented Aug 7, 2024

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps

    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)
  • Any exercise changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <exercise>/.meta/config.json (see docs)?
    • 🔬 Do the analyzer and the analyzer comments exist for this exercise? Do they need to be changed?
    • 📜 Does the design file (<exercise>/.meta/design.md) need to be updated to document new implementation decisions?
  • Practice exercise changed

    • 🌲 Do prerequisites, practices, and difficulty in config.json need to be updated?
    • 🧑‍🏫 Are the changes in accordance with the community-wide problem specifiations?

Automated comment created by PR Commenter 🤖.

@Lasamat Lasamat changed the title Fixed Typos in Instructions Fixed Typos in Instructions of Pig Latin Aug 7, 2024
@angelikatyborska
Copy link
Contributor

I don't know if they are supposed to be identical but they are not and I would atleast like to fix the typos.

Yes, they are supposed to be identical, and they get updated automatically with a tool called "configlet". See this github issue if you want to learn how to update all docs of an exercise: #1027

I can see that your PR changes pig-latin instructions to be exactly the same as they would be if updated via configlet, so it's good to merge 👍 thanks

@angelikatyborska angelikatyborska merged commit b737f80 into exercism:main Aug 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants