-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New concept exercise city-office
(docs
and typespecs
)
#693
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 So good, great investigation to discover this method for testing. Love the exercise, I think it will be awesome.
Where were you thinking about having it in the track? early after we introduce major value types? Then we could go back an add in @spec
s to other exercises.
The decision to include a struct in this exercise unfortunately forces rather late in the tree, after structs. That's not great, I might want to remove the
I don't have a strong opinion for or against this, but if some exercises got specs, then they would have to require the typespecs concept. If we don't do that, then the concept remains entirely optional 🤔 |
If you rebase on main, it will then drop the 1.6 ci check. 😄 |
I'll sneak in some more reputation points in this PR 🐍 I think every PR that adds a whole exercise should a major one. |
Looks great! |
WIP!