Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prerequisites from deprecated Practice Exercises #889

Conversation

ee7
Copy link
Member

@ee7 ee7 commented Sep 6, 2021

From the spec:

  • The "exercises.practice[].prerequisites" value must be an empty
    array if "exercises.practice[].status" is equal to deprecated

This PR resolves an otherwise-upcoming CI failure - configlet lint will enforce this rule in the future.

The mensch-aergere-dich-nicht concept exercise is also deprecated, but already had an empty prerequisites array.

From the spec [1]:

- The `"exercises.practice[].prerequisites"` value must be an empty
  array if `"exercises.practice[].status"` is equal to `deprecated`

[1] https://github.com/exercism/docs/blob/14de83e5305b/building/configlet/lint.md#rule-configjson-file-is-valid
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2021

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps
    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)

Automated comment created by PR Commenter 🤖.

@angelikatyborska
Copy link
Member

Alrighty! But "practices" doesn't need to be empty?

@angelikatyborska angelikatyborska merged commit f6dcc7b into exercism:main Sep 6, 2021
@ee7 ee7 deleted the remove-prerequisites-from-deprecated-exercises branch September 6, 2021 19:20
@ee7
Copy link
Member Author

ee7 commented Sep 6, 2021

But "practices" doesn't need to be empty?

It does. I just forgot it somehow, even though it's right there in the upcoming configlet lint output (see exercism/configlet#415 for context).

I've created #890 to make these practices arrays empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants