Add new practice exercise sieve
#665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceddlyburge
approved these changes
Mar 9, 2024
| @@ -20,7 +20,7 @@ echo "Fetching latest version of configlet..." | |||
| echo "Adding instructions and configuration files..." | |||
| UUID=$(bin/configlet uuid) | |||
| jq --arg slug "$SLUG" --arg uuid "$UUID" \ | |||
| '.exercises.practice += [{slug: $slug, name: $slug, uuid: $uuid, practices: [], prerequisites: [], difficulty: 5}]' \ | |||
There was a problem hiding this comment.
Is this to avoid a casing type problem with the title of the exercise?
There was a problem hiding this comment.
Exactly, it's too easy to miss when the name is prefilled, it happened a lot that people didn't change it (me included). At least with a big TODO you can't miss it (hopefully).
Co-authored-by: Cedd Burge <ceddlyburge@users.noreply.github.com>
|
Let's merge this when the rule is merged (or week 11 is about to start) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a while since I've implemented an exercise :)
This one will be featured on week 11 of 48in24.
This exercise is deceptively complex, because you are supposed to find prime numbers without the use of the division or modulo operator. It's very easy to solve otherwise, but then it wouldn't be the Sieve of Eratosthenes, so it will require an Elixir Analyzer rule, which I will work on next (EDIT: here).