Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to version 2 spec #31

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Upgrade to version 2 spec #31

merged 1 commit into from
Jan 6, 2022

Conversation

yshym
Copy link
Contributor

@yshym yshym commented Jan 3, 2022

No description provided.

@ErikSchierboom
Copy link
Member

@yevhenshymotiuk Thanks for working on this! Let me know when this is ready for review.

@yshym yshym force-pushed the version-2 branch 2 times, most recently from ae6684b to 314da59 Compare January 4, 2022 16:20
@yshym yshym marked this pull request as ready for review January 4, 2022 16:25
@yshym yshym requested a review from a team as a code owner January 4, 2022 16:25
@yshym
Copy link
Contributor Author

yshym commented Jan 4, 2022

@ErikSchierboom It is ready for review

ErikSchierboom
ErikSchierboom reviewed Jan 5, 2022
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Some tiny nits.

tests/example-output/expected_results.json Outdated Show resolved Hide resolved
tests/example-output/expected_results.json Outdated Show resolved Hide resolved
tests/example-all-fail/expected_results.json Outdated Show resolved Hide resolved
tests/example-empty-file/expected_results.json Outdated Show resolved Hide resolved
@yshym yshym force-pushed the version-2 branch 3 times, most recently from d85620a to 9f1e31f Compare January 5, 2022 12:13
@yshym
Copy link
Contributor Author

yshym commented Jan 5, 2022

./bin/run-tests-in-docker.sh does not work as expected. Trying to figure out why

@yshym
Copy link
Contributor Author

yshym commented Jan 5, 2022

./bin/run-tests-in-docker.sh does not work as expected. Trying to figure out why

Fixed. The issue was outdated script tool (https://github.com/exercism/emacs-lisp-test-runner/pull/31/files#diff-00a80c5821edea2ebf676056aa4c9a24e57379ef52cefecb2ccffaaf4cc362c9R41-R42) in the docker container and some inconsistency in test output

@ErikSchierboom ErikSchierboom added the x:size/massive Massive amount of work label Jan 6, 2022
@ErikSchierboom ErikSchierboom merged commit ada43d4 into exercism:main Jan 6, 2022
@ErikSchierboom
Copy link
Member

Brilliant stuff! 🎉

Once this workflow finishes, you should be able to see the results on the website.

This was referenced Jul 14, 2022
Merged
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom left review comments

Assignees
No one assigned
Labels
x:size/massive Massive amount of work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yshym @ErikSchierboom