Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bracket-push exercise in Erlang #241

Merged
merged 1 commit into from
Jun 23, 2018
Merged

bracket-push exercise in Erlang #241

merged 1 commit into from
Jun 23, 2018

Conversation

juhlig
Copy link
Contributor

@juhlig juhlig commented Apr 12, 2018

the bracket-push exercise for the Erlang track

Copy link
Member

@NobbZ NobbZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for this late review...

I requested a very small change, but I will merge on monday anyway.

@@ -0,0 +1,52 @@
-module(bracket_push_tests).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these tests based on the canonical data? If so, could you please specify the exact version of the specification in a comment like this?

% based on canonical data version 0.0.0
% https://link to raw file data

@juhlig
Copy link
Contributor Author

juhlig commented May 6, 2018

Added version and link as requested.

@NobbZ
Copy link
Member

NobbZ commented Jun 12, 2018

Sorry for taking so long...

Can you please fix the conflict and make sure the config.json is properly formatted?

edit

I try to merge in faster then!

@NobbZ NobbZ merged commit 3a45d23 into exercism:master Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants