Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[poker] implement exercise #295

Merged
merged 1 commit into from
Oct 23, 2018
Merged

[poker] implement exercise #295

merged 1 commit into from
Oct 23, 2018

Conversation

chilikk
Copy link
Contributor

@chilikk chilikk commented Oct 4, 2018

Refs #196

@juhlig
Copy link
Contributor

juhlig commented Oct 16, 2018

In reference to #278, please remove the test version related functions from the test, example solution, and module stub.

Instead, at the top of the test file, note the version of the canonical data it implements (1.1.0 at the time of this writing) and a link to the raw view of the canonical data on github, like this:

%% based on canonical data version 1.1.0
%% https://raw.githubusercontent.com/exercism/problem-specifications/master/exercises/poker/canonical-data.json

Otherwise, I'd say it's good :)

@chilikk
Copy link
Contributor Author

chilikk commented Oct 22, 2018

Thanks, done!

@juhlig
Copy link
Contributor

juhlig commented Oct 23, 2018

Thanks :)

Just one more thing, I might have overlooked that in your first commit (sorry): As a convention, the stub functions in the module skeleton should return undefined (yours returns []). If you could change that, it's good to go :)

@chilikk
Copy link
Contributor Author

chilikk commented Oct 23, 2018

Oh, ok, sure. I guess I was just trying to follow my own spec for the function.

@juhlig juhlig merged commit daa394c into exercism:master Oct 23, 2018
@juhlig
Copy link
Contributor

juhlig commented Oct 23, 2018

Merged, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants