Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CoC docs here match website #6352

Open
SethFalco opened this issue May 6, 2022 · 8 comments
Open

Make CoC docs here match website #6352

SethFalco opened this issue May 6, 2022 · 8 comments

Comments

@SethFalco
Copy link
Contributor

On the websites contact us and abuse page, it uses this email address and requests that [CoC] be put in the subject.

Probably worth having that in the README as well?

#6351

Suggested change:

- If you need to report a code of conduct violation, please email us at team@exercism.org.
+ If you need to report a code of conduct violation, please email us at abuse@exercism.org and include \[CoC\] in the subject line. We will deal with all CoC issues as a priority.

Related

@iHiD
Copy link
Member

iHiD commented May 8, 2022

@SethFalco Thanks for this.

This actually needs changing at https://github.com/exercism/org-wide-files/blob/main/CODE_OF_CONDUCT.md - that's the central one that's copied into all repositories. Changes here will get overriden at the next sync from that central place. Would you like to PR there instead? I'm 👍 on the change FYI.

@SethFalco
Copy link
Contributor Author

SethFalco commented May 8, 2022

Are you familiar with .github repos?
If not, it may be something worth looking into.

If you make a repo at exercism/.github and just put the CODE_OF_CONDUCT.md in there, there's no need to copy and paste it everywhere, GitHub infers that it's for all repos on the organization, and it gets displayed as-if it were in each repository. (Unless a particular repository overrides it with its own version.)

See documentation on organization wide settings or "health files" in the GitHub Docs.

An example: https://github.com/elypia/.github


Meanwhile sure! I'll make a PR over there.

Edit:
Oh I'm an idiot. XD
Excercism already has one, so I guess it would be known.

https://github.com/exercism/.github

@iHiD
Copy link
Member

iHiD commented May 8, 2022

Appreciate you letting us know! 💙 But yes, we're already familiar 🙂 We use org-wide files as our needs a bit more complex in general and this copy/paste mechanism works quite well for us.

That said, for CoC etc. we could maybe consider only copying it into repos if they are amends to it, so as not to require all maintainers to have to accept updates when they happen. Maybe one for @ErikSchierboom to consider, although probably lower priority atm, as our currently system works ok enough.

Regardless, thanks for PRing over there!

@SethFalco
Copy link
Contributor Author

Ahh actually there might be some confusion.
This PR was not updating the CoC itself, it was updating the README.

Looks like the central repository wouldn't be the one to update for this?

@iHiD
Copy link
Member

iHiD commented May 8, 2022

Oh, I see! Sorry Yes, please update that. But also please update the org-wide files bit to add the bit about the subject heading too. Double extra-rep for you 😉

@SaschaMann
Copy link
Contributor

SaschaMann commented May 8, 2022

That said, for CoC etc. we could maybe consider only copying it into repos if they are amends to it, so as not to require all maintainers to have to accept updates when they happen.

Unless it changed, the files in .github are only displayed on the website, they're not actually part of the repo itself. Depending on how you interact with GitHub, e.g. when using Desktop clients or extensions, you will never get to see it and I'd imagine even on the web interface changes to it would be missed more easily than when there's a PR that changes them.

For the second part: org-wide-files PRs were originally meant to be automerged and I still think that's a good idea, but afaiu Erik will force-merge them after a few days anyway.

@ErikSchierboom
Copy link
Member

but afaiu Erik will force-merge them after a few days anyway.

For the last batch, I've kept the PRs open for 1,5 weeks now (I should be merging them soon). But in general, I usually try to merge them sooner than later.

@iHiD
Copy link
Member

iHiD commented Aug 16, 2022

@ErikSchierboom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants